Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DTDataIntegrityTask for multithreading #3386

Merged
merged 1 commit into from Apr 22, 2014
Merged

fix DTDataIntegrityTask for multithreading #3386

merged 1 commit into from Apr 22, 2014

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 17, 2014

  • make the DTRawToDigi producer put DTControlData and DTDDUWords collections in the event
  • convert DTDataIntegrityTask from a Service to an EDAnalizer
  • add the DTDataIntegrityTask to the sequence of DQM sources
  • fix from Carlo Battilana carlo.battilana@cern.ch: clean the DDU controlData structure between events

@mgalanti @fwyzard
fix DTDataIntegrityTask for multithreading
d8c055d 
  - make the DTRawToDigi producer put DTControlData and DTDDUWords collections in the event
  - convert DTDataIntegrityTask from a Service to an EDAnalizer
  - add the DTDataIntegrityTask to the sequence of DQM sources
  - fix from Carlo Battilana <carlo.battilana@cern.ch>: clean the DDU controlData structure between events
@fwyzard fwyzard mentioned this pull request Apr 17, 2014
Closed
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 17, 2014

Integrates a fix from @battibass on top of #3367 , and rebase to clean up the history.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_1_X.

fix DTDataIntegrityTask for multithreading

It involves the following packages:

DQM/DTMonitorModule
DataFormats/DTDigi
DataFormats/FEDRawData
EventFilter/DTRawToDigi
HLTrigger/special

@perrotta, @cmsbuild, @civanch, @thspeer, @danduggan, @fwyzard, @emeschi, @mdhildreth, @Martin-Grunewald, @anton-a, @nclopezo, @rovere, @deguio, @slava77, @mommsen, @Degano, @ojeda can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3386/945/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3386/945/summary.html

@danduggan
Copy link
Contributor

+1

@mommsen
Copy link
Contributor

mommsen commented Apr 22, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Apr 22, 2014
@nclopezo
Merge pull request #3386 from fwyzard/DTDQM_Multithread
8037ca8 
fix DTDataIntegrityTask for multithreading
@nclopezo nclopezo merged commit 8037ca8 into cms-sw:CMSSW_7_1_X Apr 22, 2014
@fwyzard fwyzard deleted the DTDQM_Multithread branch April 25, 2014 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available daq-approved dqm-approved fully-signed hlt-approved reconstruction-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@fwyzard @cmsbuild @civanch @slava77 @Martin-Grunewald @danduggan @mommsen @nclopezo @mgalanti