Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 11_3] Fix prodlike workflow to use DIGI instead of DIGI:pdigi_valid #33895

Merged

Conversation

srimanob
Copy link
Contributor

PR description:

Backport of #33847

PR validation:

Get proper cmsDriver(s) when use
runTheMatrix.py --what upgrade -l 23234.0,23234.21,23434.21,23434.9921 --dryRun

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_11_3_X.

It involves the following packages:

Configuration/PyReleaseValidation
SimGeneral/MixingModule

@civanch, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 23234.21, 23434.21, 23434.9921

@srimanob
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-733719/15431/summary.html
COMMIT: 10a0b98
CMSSW: CMSSW_11_3_X_2021-05-30-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33895/15431/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-733719/23234.21_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+MiniAOD
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-733719/23434.9921_TTbar_14TeV+2026D49PU_PMXS1S2ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+MiniAODPU

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877742
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2877713
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented May 30, 2021

+1

@srimanob
Copy link
Contributor Author

Urgent

Expect to include it in the next 11_3 release for Phase-2 production @qliphy @silviodonato

@chayanit
Copy link

+1

@srimanob
Copy link
Contributor Author

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor Author

@qliphy @silviodonato
I believe this is the last piece needed for the 11_3 Phase2 campaign. Thanks.

@silviodonato
Copy link
Contributor

@qliphy @silviodonato
I believe this is the last piece needed for the 11_3 Phase2 campaign. Thanks.

thanks, it will be included in the next 11_3_X release

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b01bfb6 into cms-sw:CMSSW_11_3_X May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants