New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BP CMSSW_106X] Add protection for missing handleExtResults #33921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey ElectronSeed BDT ValueMaps, code review
… based on ID score, add run2_miniAOD_UL modifier, code review
…O/AOD and MINIAOD
…eed::features method
…12-02-2300 [backport] Add new Pythia filter to select particles based on ancestor (i.e. further back than mother)
…ts_106X Add low-pT electrons to MINIAOD, update ID, improve end user experience (back port of 31220)
…gm_10_6_X Add low pT electron payloads to Run 2 data/MC and Run 3 MC GTs [10_6_X]
…12-02-2300 [backport] Avoid rejecting good events in PythiaFilterMultiAncestor.cc
[10_6_X] feat: allow for not sorting during PATJetUpdater call
…no_jercVars_PuId [NanoAOD, JMENanoAOD] Backport of cms-sw#33824 (Remove jercVars variables, update puId config) to 10_6_X
…lectromMatching_PR_backport Extension of electron matching in nanoAOD (backport)
cmsbuild
added
alca-pending
analysis-pending
code-checks-pending
core-pending
db-pending
dqm-pending
fastsim-pending
generators-pending
geometry-pending
hlt-pending
l1-pending
operations-pending
orp-pending
pdmv-pending
pending-signatures
reconstruction-pending
simulation-pending
tests-pending
upgrade-pending
visualization-pending
xpog-pending
labels
May 31, 2021
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33921/22994 ERROR: Build errors found during clang-tidy run.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alca-pending
analysis-pending
code-checks-rejected
core-pending
db-pending
dqm-pending
fastsim-pending
generators-pending
geometry-pending
hlt-pending
l1-pending
operations-pending
orp-pending
pdmv-pending
pending-signatures
reconstruction-pending
simulation-pending
tests-pending
upgrade-pending
visualization-pending
xpog-pending
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a protection against the error:
Happening due to empty handleExtResults. This is a rare case.
More details in:
https://its.cern.ch/jira/browse/CMSCOMPPR-17789
Validated on the affected events:
RECO --conditions 106X_dataRun2_v32 --customise Configuration/DataProcessing/Utils.addMonitoring --datatier NANOAOD --era Run2_2017,run2_nanoAOD_106Xv1 --eventcontent NANOEDMAOD --filein placeholder.root --fileout file:ReReco-Run2017E-JetHT-UL2017_MiniAODv1_NanoAODv2-00002.root --nThreads 2 --no_exec --python_filename ReReco-Run2017E-JetHT-UL2017_MiniAODv1_NanoAODv2-00002_0_cfg.py --scenario pp --step NANO --data
file on which we should be able to reproduce the crash at:
This PR is a backport of Add protection for missing handleExtResults