New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 5_3_X #3393
IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 5_3_X #3393
Conversation
…place clusterScale and densityFactor with single distanceRatio variable
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_5_3_X. IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 5_3_X It involves the following packages: DataFormats/BTauReco @nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks. |
+1 |
@@ -19,6 +19,7 @@ namespace reco { | |||
enum TaggingVariableName { | |||
jetEnergy = 0, // jet energy | |||
jetPt, // jet transverse momentum | |||
trackJetPt, // track-based jet transverse momentum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it clear that nobody uses int values for the enums?
Insertion of one new value will mess it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I am aware, the only situations when int values are used directly is when loops over the full list are performed. @pvmulder should be able to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed.
This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it? |
…CMSSW_5_3_16 IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 5_3_X
Backport of #2941 but without any changes to the RECO sequence