Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 5_3_X #3393

Conversation

ferencek
Copy link
Contributor

Backport of #2941 but without any changes to the RECO sequence

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_5_3_X.

IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 5_3_X

It involves the following packages:

DataFormats/BTauReco
PhysicsTools/PatAlgos
RecoBTag/SecondaryVertex
RecoVertex/AdaptiveVertexFinder

@nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @GiacomoSguazzoni, @rovere, @nhanvtran, @cerati, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link

vadler commented May 8, 2014

+1

@@ -19,6 +19,7 @@ namespace reco {
enum TaggingVariableName {
jetEnergy = 0, // jet energy
jetPt, // jet transverse momentum
trackJetPt, // track-based jet transverse momentum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it clear that nobody uses int values for the enums?
Insertion of one new value will mess it up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I am aware, the only situations when int values are used directly is when loops over the full list are performed. @pvmulder should be able to confirm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed.

@slava77
Copy link
Contributor

slava77 commented May 9, 2014

+1

for #3393 691ec44

CMSSW_5_3_X_2014-05-08-1400 (test area sign5317a in a combination of
pulls 3168 3222 3223 3393 3672 3749)
No regressions observed

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

davidlange6 added a commit that referenced this pull request May 9, 2014
…CMSSW_5_3_16

IVF cleanup + trackJetPt as TaggingVariable: Backport from 7_1_X to 5_3_X
@davidlange6 davidlange6 merged commit 95ec779 into cms-sw:CMSSW_5_3_X May 9, 2014
@ferencek ferencek deleted the IVFcleanup-trackJetPt_from-CMSSW_5_3_16 branch May 9, 2014 11:43
@ferencek ferencek restored the IVFcleanup-trackJetPt_from-CMSSW_5_3_16 branch May 12, 2014 20:56
@ferencek ferencek deleted the IVFcleanup-trackJetPt_from-CMSSW_5_3_16 branch May 12, 2014 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants