Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal DB payload comparison viewer #33930

Merged
merged 1 commit into from Jun 9, 2021

Conversation

jeanfay
Copy link
Contributor

@jeanfay jeanfay commented Jun 1, 2021

PR description:

New features in DB PayloadInspector to compare IOVs in 2 different tags

PR validation:

Tests done in command line with getPayloadData.py, plots (png) correctly produced

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33930/23007

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2021

A new Pull Request was created by @jeanfay (Fay) for master.

It involves the following packages:

CondCore/EcalPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

@jeanfay please fix the PR title to something more descriptive. Please also attach the .png you mentioned in the PR description

@jeanfay jeanfay changed the title commit message Ecal DB payload comparison viewer Jun 1, 2021
@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2021

@jeanfay See above comment from @silviodonato , please also attach the .png you mentioned in the PR description

@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2021

From Jean:
"one example among many others :
EcalPedestals"

@ggovi
Copy link
Contributor

ggovi commented Jun 8, 2021

+1
Too early, waiting for test results...

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-033a07/15771/summary.html
COMMIT: 03363a5
CMSSW: CMSSW_12_0_X_2021-06-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33930/15771/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2862491
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Jun 9, 2021

+1

@cmsbuild cmsbuild merged commit ddff3ef into cms-sw:master Jun 9, 2021
@ggovi
Copy link
Contributor

ggovi commented Jun 9, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants