Backport (of #33966) to 106X: Adding necessary electron structures for low pT part of slimmedElectron collection

[jainshilpi]

This is just a backport of #33966 which adds the needed structures to all the electrons to enable low pT electron analyses using slimmedElectron collection.
Tested on WFs: 136.898

@bainbrid @cavalari

[cmsbuild]

A new Pull Request was created by @jainshilpi for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Adding necessary electron structures for low pT part of slimmedElectron collection #33966

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3ddaa/15642/summary.html
COMMIT: 8bde90d
CMSSW: CMSSW_10_6_X_2021-06-03-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33977/15642/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215543
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215208
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[slava77]

Suggested change

	bParking.toModify(slimmedElectrons,dropCorrections="0")
	bParking.toModify(slimmedElectrons,dropIsolations="0")
	bParking.toModify(slimmedElectrons,dropShapes="0")
	bParking.toModify(slimmedElectrons,dropClassifications="0")
	bParking.toModify(slimmedElectrons,dropCorrections="0", dropIsolations="0", dropShapes="0", dropClassifications="0")

this is simpler to maintain if we need to extend to another modifier

[slava77]

@jainshilpi
are you available to update this PR?

[jainshilpi]

Hi Slava, I missed that comment. Just pushed the modification.

[slava77]

Hi Slava, I missed that comment. Just pushed the modification.

Thank you.

[slava77]

test parameters:

• workflows = 136.898,1304.181

[perrotta]

backport of #33966

[cmsbuild]

Pull request #33977 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3ddaa/15723/summary.html
COMMIT: 311359e
CMSSW: CMSSW_10_6_X_2021-06-07-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33977/15723/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215543
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215208
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #33977 311359e

• code changes are in line with the PR description and the follow up review
  • the updates are consistent with Adding necessary electron structures for low pT part of slimmedElectron collection #33966 under the constraints of the no-change policy
• jenkins tests pass and comparisons with the baseline show no differences
• miniAOD output of 136.898 (bParking wf) here compared to a test in LowPtElectrons: final energy regression and ID (back port of 32391) #33589 show a small increase in the size of slimmedElectrons collection, as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1