Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAQ_RECONSTRUCTION] Apply code-checks/format with misc-definitions-in-headers #34037

Merged
merged 1 commit into from Jun 9, 2021
Merged

[DAQ_RECONSTRUCTION] Apply code-checks/format with misc-definitions-in-headers #34037

merged 1 commit into from Jun 9, 2021

Conversation

smuzaffar
Copy link
Contributor

code-checks/format applied on full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34037/23172

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

EventFilter/Utilities

@perrotta, @emeschi, @cmsbuild, @slava77, @jpata, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor

smorovic commented Jun 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e63375/15775/summary.html
COMMIT: 3af1400
CMSSW: CMSSW_12_0_X_2021-06-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34037/15775/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2862520
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2862497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor

smorovic commented Jun 8, 2021

+1

@perrotta
Copy link
Contributor

perrotta commented Jun 9, 2021

+1

  • Trivial code-checks/format update, with no effect on outputs

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 9, 2021

+1

@cmsbuild cmsbuild merged commit 2e51b34 into cms-sw:master Jun 9, 2021
@smuzaffar smuzaffar deleted the 12_0-code-checks-DAQ_RECONSTRUCTION branch June 15, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants