Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameters for dealing w/ strip mono layers (useful for confDB) #3421

Merged
merged 2 commits into from Apr 24, 2014

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Apr 22, 2014

add parameters MTIB, MTID, MTEC and MTOB for dealing w/ strip mono layers
this is needed for having them in confDB

@mtosi
Copy link
Contributor Author

mtosi commented Apr 22, 2014

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_1_X.

add parameters for dealing w/ strip mono layers (useful for confDB)

It involves the following packages:

RecoTracker/TkSeedingLayers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

Hi,

You should probably also fix up:
RecoTracker/TkSeedingLayers/python/PixelAndStripLayerPairs_cfi.py
and
RecoTracker/TkSeedingLayers/python/TobTecLayerPairs_cfi.py
for the added PSets.

@mtosi
Copy link
Contributor Author

mtosi commented Apr 22, 2014

@cerati @rovere @Martin-Grunewald

could I change the above configuration in something like

from RecoTracker.TkSeedingLayers.seedingLayersEDProducer_cfi import *
PixelLessLayerPairs = seedingLayersEDProducer.clone()
PixelLessLayerPairs.layerList = cms.vstring( ...)
PixelLessLayerPairs.layerList = cms.vstring( ...)
etc.

?

@Martin-Grunewald
Copy link
Contributor

That would ensure things are always in sync!

@mtosi
Copy link
Contributor Author

mtosi commented Apr 22, 2014

@Martin-Grunewald @cerati @rovere
I've just updated the PR
the seed layers configurations import from the main one
w/ the idea of having them always in synch

@cmsbuild
Copy link
Contributor

Pull request #3421 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mtosi
Copy link
Contributor Author

mtosi commented Apr 23, 2014

ciao,
any chance for having it integrated w/in pre7 ?
it would be really helpful .... thanks
@perrotta @Martin-Grunewald @rovere @cerati @fwyzard

@slava77
Copy link
Contributor

slava77 commented Apr 24, 2014

+1

for #3421 6c43a75

tested in CMSSW_7_1_X_2014-04-23-0200
(test area sign352)
no regressions observed on short matrix tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Apr 24, 2014
RecoTracker/TkSeedingLayers -- add parameters for dealing w/ strip mono layers (useful for confDB)
@nclopezo nclopezo merged commit 00aaa23 into cms-sw:CMSSW_7_1_X Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants