BackPort(#33983) MuonHLTSeed MVA Classifier to 113X

[wonpoint4]

PR description:

This PR is a backport of #33983
This adds a new class for a MVA based TrajectorySeed quality estimator and a new EDProducer for selecting high quality seeds for the Run 3 Muon HLT development.

The PR has no impact on any existing modules or codes.

The work has been presented and approved by the Muon POG.
The latest presentation given at Muon POG (HLT+RECO) meeting can be found in here: https://indico.cern.ch/event/1012931/#6-update-on-inside-out-seeding

We need data files in https://github.com/cms-data/RecoMuon-TrackerSeedGenerator , but 11_3_X dosen't have these.
Could you please let us know what should be done?

[cmsbuild]

A new Pull Request was created by @wonpoint4 (Won Jun) for CMSSW_11_3_X.

It involves the following packages:

RecoMuon/TrackerSeedGenerator

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from MuonHLTSeed MVA Classifier 120X #33983

[perrotta]

please test

[perrotta]

backport of #33983

[perrotta]

@smuzaffar could you please backport also cms-sw/cmsdist#7027 to 11_3_X?
That updated tag for RecoMuon-TrackerSeedGenerator only adds new data files, without touching any of the existing ones

[smuzaffar]

@perrotta , cms-sw/cmsdist#7058 is for 11.3.X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-676f36/16210/summary.html
COMMIT: ff96601
CMSSW: CMSSW_11_3_X_2021-06-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34228/16210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1266 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877861
• DQMHistoTests: Total failures: 3678
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2874141
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.699 KiB( 37 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[perrotta]

@perrotta , cms-sw/cmsdist#7058 is for 11.3.X

Thank you @smuzaffar !

[perrotta]

@wonpoint4 the latest 11_3_X IB should contain the needed external, merged with cms-sw/cmsdist#7058
Could you please test that this PR can run on HLT, with a similar script as the one that you prepared for the master? Or just make such a script available somewhere?

[wonpoint4]

Always thanks to you all.
Here's the recipe in the latest 11_3_X IB.

cmsrel CMSSW_11_3_X_2021-06-24-1100
cd CMSSW_11_3_X_2021-06-24-1100/src/
cmsenv
git cms-init
git cms-merge-topic 34228

# Muon HLT customizers for Run 3
git cms-addpkg HLTrigger/Configuration
git clone -b dev https://github.com/khaosmos93/MuonHLTForRun3.git HLTrigger/Configuration/python/MuonHLTForRun3

scram b -j 8

# get simple Muon HLT menu
hltGetConfiguration /dev/CMSSW_11_3_0/GRun/V14 --type GRun \
--path HLTriggerFirstPath,HLT_IsoMu24_v*,HLT_Mu50_v*,HLTriggerFinalPath,HLTAnalyzerEndpath \
--unprescale --cff >$CMSSW_BASE/src/HLTrigger/Configuration/python/HLT_MuonHLT_cff.py
# In case there is a problem with hltGetConfiguration, this HLT_MuonHLT_cff.py is also available in /afs/cern.ch/user/w/wjun/public/

# cmsDriver
cmsDriver.py hlt_muon \
--python_filename=hlt_muon_Run3_mc.py \
--step HLT:MuonHLT \
--process MYHLT --era=Run3 \
--mc --conditions=113X_mcRun3_2021_realistic_v10 \
--customise=HLTrigger/Configuration/MuonHLTForRun3/customizeMuonHLTForRun3.customizeMuonHLTForDoubletRemoval \
--customise=HLTrigger/Configuration/MuonHLTForRun3/customizeMuonHLTForRun3.customizeMuonHLTForCscSegment \
--customise=HLTrigger/Configuration/MuonHLTForRun3/customizeMuonHLTForRun3.customizeMuonHLTForGEM \
--customise=HLTrigger/Configuration/MuonHLTForRun3/customizeMuonHLTForRun3.customizerFuncForMuonHLTSeeding \
--filein=root://xrootd-cms.infn.it//store/mc/Run3Winter21DRMiniAOD/WprimeToMuNu_M-5000_TuneCP5_14TeV-pythia8/GEN-SIM-DIGI-RAW/FlatPU0to80_112X_mcRun3_2021_realistic_v16-v2/30000/1f31ab0f-41b1-42a4-a1e2-\
865d2ca72e29.root \
-n 100 --no_output --no_exec

# in order to change parameters of the new muon seed classifier,
# e.g. to choose top 20 seeds with the highest quality, modify
# the following line in hlt_muon_Run3_mc.py
#process = customizerFuncForMuonHLTSeeding(process)
# to
#process = customizerFuncForMuonHLTSeeding(process, newProcessName='MYHLT', doSort=True, nSeedsMaxBs = (20, 20), nSeedsMaxEs = (20, 20))

# optionally, add the following lines at the end of the configuration file to print out full trigger reports
#process.options.wantSummary = cms.untracked.bool( True )
#if 'MessageLogger' in process.__dict__:
#     process.MessageLogger.TriggerSummaryProducerAOD = cms.untracked.PSet()
#     process.MessageLogger.L1GtTrigReport = cms.untracked.PSet()
#     process.MessageLogger.L1TGlobalSummary = cms.untracked.PSet()
#     process.MessageLogger.HLTrigReport = cms.untracked.PSet()
#     process.MessageLogger.FastReport = cms.untracked.PSet()
#     process.MessageLogger.ThroughputService = cms.untracked.PSet()
#     process.MessageLogger.cerr.FwkReport.reportEvery = 1

# test run
cmsRun hlt_muon_Run3_mc.py

[perrotta]

Thank you @wonpoint4

In 11_3, when I arrive at cmsDriver i get the error

AttributeError: 'Process' object has no attribute 'HLTSchedule'

which does not allow producing the actual hlt_muon_Run3_mc.py

That worked in the master for me... That's annoying... Together with the impossibility to run the hltGetConfiguration command, which I had also in the master, it suggests me that I have some misconfiguration for HLT even after issuing the cmsenv command. I'll try to work it out.

In the meanwhile, could you please either provide also the hlt_muon_Run3_mc.py file in your afs area, or test yourself with the PR in 11_3 and confirm that there were no mistakes hidden in the code, and that everything can run to completion without error?

[wonpoint4]

Thank you perrotta

I and my colleague tested the recipe above again, and it worked well for us. That's strange...
I upload hlt_muon_Run3_mc.py in the /afs/cern.ch/user/w/wjun/public/ just like HLT_MuonHLT_cff.py
Thanks again!

[perrotta]

+1

• Identical backport of MuonHLTSeed MVA Classifier 120X #33983: it adds a new class for a MVA based TrajectorySeed quality estimator and a new EDProducer for selecting high quality seeds for the Run 3 Muon HLT development.
• The PR has no impact on any existing modules or codes: jenkins tests pass and show no difference wrt baseline
• Code tested running succesfully with the dedicated HLT script provided
• Externals already merged with [11.3] Update tag for RecoMuon-TrackerSeedGenerator to V00-01-00 cmsdist#7058

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Thank you perrotta

I and my colleague tested the recipe above again, and it worked well for us. That's strange...
I upload hlt_muon_Run3_mc.py in the /afs/cern.ch/user/w/wjun/public/ just like HLT_MuonHLT_cff.py
Thanks again!

Thank you @wonpoint4 , it worked: it was just a mistake of mine,
In case you need it further, please fix (your own) HLTrigger/Configuration/python/MuonHLTForRun3/customizeMuonHLTForRun3.py with the updated parameter names.

[qliphy]

+1