Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of the unified track selection and refitting sequence. #3430

Conversation

ghellwig
Copy link

This tool provides an easy and unified configuration of tracker alignment and tracker alignment validation workflows.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Hellwig) for CMSSW_7_0_X.

First version of the unified track selection and refitting sequence.

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@mmusich, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghellwig
Copy link
Author

This is a backport of #3429 which is needed for ongoing alignment campaigns and for validation of code development using datasets which will be available only for this release cycle.

@frmeier
Copy link
Contributor

frmeier commented Apr 22, 2014

This has been presented in the alignment meeting of Apr 17 (https://indico.cern.ch/event/305399/#2014-04-17) and the conveners asked for a PU. Benefit is a simplification of the configuration files with the advantage of consistency among alignment and validation tasks. We strongly support this PR.
Frank, for the alignment conveners.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Apr 29, 2014

@frmeier @mmusich
#3429 is in 7.1.0.pre7: if you give me confirmation that the new sequence is validated there, I can sign and ask for back port.
Thanks

@diguida
Copy link
Contributor

diguida commented Apr 29, 2014

+1
@mmusich confirmed privately that the sequence is ok: validation plots are the same as the ones in the talk quoted above.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Apr 29, 2014
…itting-sequence-70X

First version of the unified track selection and refitting sequence.
@davidlange6 davidlange6 merged commit 1e694af into cms-sw:CMSSW_7_0_X Apr 29, 2014
@ghellwig ghellwig deleted the unified-trackselection-and-refitting-sequence-70X branch May 5, 2014 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants