Update TMB matching parameters for CSC trigger primitives

[dildick]

PR description:

Three parameters I forgot to update in #34245.

• In Run-2 we only match an ALCT to the first CLCT (matchEarliestClctOnly). With the introduction of the preferred BX windows, we now also do this in Run-3 and Phase-2.
• tmbDropUsedClcts was mistakenly set to False for Run-2. That should be True. But it is False for Run-3 and Phase-2; CLCTs can be reused.
• L1A window size for Run-3 OTMBs ( tmbL1aWindowSize) is 5 BX wide, not 7.

PR validation:

Code was tested on 10k events of B904 cosmic data (to test Run-3 algorithm).

DataVsEmulatorComparison_20210701.pdf

It was also tested on 26k events of 2018D ZeroBias data Run 322022 (to test Run-2 algorithm). Chambers ME+1/1/9, ME+1/1/10 and ME+1/1/11 were excluded in this comparison because we had loaded prototype Phase-2 firmware on those chambers.

CSC_dataVsEmul_CMS_Run_322022_20210701_prefix.pdf

CSC_dataVsEmul_CMS_Run_322022_20210701_postfix.pdf

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23641

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5ad07/16405/summary.html
COMMIT: 5bb331b
CMSSW: CMSSW_12_0_X_2021-07-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34308/16405/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785711
• DQMHistoTests: Total failures: 77
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785612
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23658

• This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23658/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23658/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[dildick]

This is the most recent report from the B904 test-stand after relocating the CCLUT part in the CLCT processors.

CSC_dataVsEmul_B904_Cosmic_Run_210609_142357_20210702_RelocateCCLUT.pdf

I don't see any changes in the CLCT or LCT histograms. The relocating does make sense; in the firmware CCLUT is also only applied after the pattern finding is complete.

But there are still 15 too many CLCTs found after re-emulation of 10,000 events, pointing to possibly an issue with finding the second CLCT (work in progress).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34308/23660

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #34308 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[dildick]

I also added the number of histograms entries in the pdf file, e.g.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5ad07/16457/summary.html
COMMIT: dd71e9f
CMSSW: CMSSW_12_0_X_2021-07-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34308/16457/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785924
• DQMHistoTests: Total failures: 82
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2785819
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1