Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeamSpotOnline tags for CRUZET [11_3_X] #34333

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Jul 5, 2021

PR description:

This PR updates the BeamSpotOnline tags to the "production" version (i.e. removed the word Test from the tag name)
to be used at HLT and in Express for CRUZET onwards:

  • udpated names of the tags in the DQM online clients that write the payloads
  • removed the ESSource in the onlinebeammonitor DQM client (avaid crash from multiple sources)
  • add to autoCond.py HLT and Express candidate GTs which contain the new tags:

As agreed with TRK DPG and POG (FYI @mtosi @mmusich) for now the tags only contain one payload with since = 1 and with a "fakeBS":

 Beam type    = -1
       X0     = 0.0001 +/- 0 [cm]
       Y0     = 0.0001 +/- 0 [cm]
       Z0     = 0.0001 +/- 0 [cm]
 Sigma Z0     = 15 +/- 0 [cm]
 dxdz         = 0 +/- 0 [radians]
 dydz         = 0 +/- 0 [radians]
 Beam Width X = 0.1 +/- 0 [cm]
 Beam Width Y = 0.1 +/- 0 [cm]
 Emittance X  = 0 [cm]
 Emittance Y  = 0 [cm]
 Beta star    = 0 [cm]
 Last Lumi    = 1
 Last Run     = 1
 Last Fill    = 0

The GT diffs are as follow:
HLT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_Candidate_2021_07_02_14_05_25/113X_dataRun3_HLT_v2
Express: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_Candidate_2021_07_02_14_38_40/113X_dataRun3_Express_v3

IMPORTANT NOTE
This PR is needed to DQM in order to test the candidates, once both DQM and HLT confirm the candidates are fine they will be turned into versioned GTs and I will update this PR. This is needed for CRUZET.
FYI @qliphy @silviodonato @amassiro @boudoul

-EDIT-
DQM and HLT validated the candidates (HN message), so I made the versioned GTs for CRUZET by copying the candidates:
HLT: 113X_dataRun3_HLT_v3
Express: 113X_dataRun3_Express_v4
The new diffs are:
Run 3 data HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v2/113X_dataRun3_HLT_v3

Run 3 data (express)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v3/113X_dataRun3_Express_v4

PR validation:

Tested with:

runTheMatrix.py -l 138.2 --ibeos -j 8
addOnTests.py -j 8

Back/Forward-port:

This will be forward-ported to master.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

A new Pull Request was created by @francescobrivio for CMSSW_11_3_X.

It involves the following packages:

Configuration/AlCa
DQM/Integration

@malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @rvenditti, @cmsbuild, @jfernan2, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @makortel, @tocheng, @Martin-Grunewald, @mmusich, @threus, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 138.2

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8cfd6/16470/summary.html
COMMIT: cfad201
CMSSW: CMSSW_11_3_X_2021-07-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34333/16470/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e8cfd6/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877978
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877955
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 5, 2021

+1
Tested sucessfully at Online DQM in P5.
@francescobrivio @gennai Perhaps we need a forward port of at least the changes in the OnlineBeamSpot Monitor to not lose this fix for the master version.
Thank you!

@francescobrivio
Copy link
Contributor Author

+1
Tested sucessfully at Online DQM in P5.
@francescobrivio @gennai Perhaps we need a forward port of at least the changes in the OnlineBeamSpot Monitor to not lose this fix for the master version.
Thank you!

thanks @jfernan2! A forward port is planned as soon as we also get confirmation of the candidates from HLT (hopefully tomorrow morning) and we can create versioned GTs to be put in autoCond.

@gennai
Copy link
Contributor

gennai commented Jul 6, 2021

I am on it now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

Pull request #34333 was updated. @malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @rvenditti, @cmsbuild, @jfernan2, @tlampen, @pohsun, @francescobrivio, @tvami can you please check and sign again.

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 138.2

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

urgent

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 6, 2021

@francescobrivio should we test again at P5 the new GTs 113X_dataRun3_HLT_v3/4 or are they copies of the candidates 113X_dataRun3_Express_Candidate_2021_07_02_* ?
Thanks

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Jul 6, 2021

@francescobrivio should we test again at P5 the new GTs 113X_dataRun3_HLT_v3/4 or are they copies of the candidates 113X_dataRun3_Express_Candidate_2021_07_02_* ?
Thanks

@jfernan2 They are exact copies of the candidates you already tested, see:
HLT: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_Candidate_2021_07_02_14_05_25/113X_dataRun3_HLT_v3
Express: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_Candidate_2021_07_02_14_38_40/113X_dataRun3_Express_v4
I updated the PR description to make it clear!

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 6, 2021

OK, thanks for the confirmation!!

@qliphy
Copy link
Contributor

qliphy commented Jul 6, 2021

forward port to #34348

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8cfd6/16486/summary.html
COMMIT: 018b6f4
CMSSW: CMSSW_11_3_X_2021-07-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34333/16486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e8cfd6/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877978
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2877949
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

+alca

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

+1

@cmsbuild cmsbuild merged commit 7f3a22a into cms-sw:CMSSW_11_3_X Jul 7, 2021
@francescobrivio francescobrivio deleted the alca-CRUZET_GTs_11_3_X branch August 9, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants