Delete some unused code in the Core packages

[wddgit]

PR description:

Deletes several fragments of unused code in Core packages (plus a little from "scram b code-format").

I noticed this unused code while preparing the ProcessBlock Persistence pull request, although they are unrelated to ProcessBlock. It would be nice to get these trivial changes merged quickly so I can rebase the ProcessBlock pull request on top of them.

PR validation:

Relies on existing unit tests. The fact that it compiles is likely sufficient to test this as it only deletes things.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34406/23809

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/interface/ScheduleItems.h modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File FWCore/Framework/interface/moduleAbilities.h modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File FWCore/Framework/src/ScheduleItems.cc modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File IOPool/Input/src/RootDelayedReader.cc modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File IOPool/Input/src/RootTree.cc modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File IOPool/Input/src/RootTree.h modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File IOPool/Output/interface/PoolOutputModule.h modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File IOPool/Output/src/PoolOutputModule.cc modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Framework (core)
IOPool/Input (core)
IOPool/Output (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39d130/16615/summary.html
COMMIT: 14a4291
CMSSW: CMSSW_12_0_X_2021-07-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34406/16615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5154 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786260
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786237
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[makortel]

+1

Differences are related to #34409

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1