Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Run-3 MC GTs containing new pixel bad components #34450

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jul 13, 2021

PR description:

Tracker DPG has an updated list of bad components for the Run-3 MCs. These GTs differ from the current autoCond GTs only in the tags requested in the HN message of [1] and presentation at the AlCaDB meeting [2], see also the diffs [3-5]

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4423.html
[2] https://indico.cern.ch/event/1056952/#5-run3-pixel-bad-components-fo
[3] 2021: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2021_realistic_v2/120X_mcRun3_2021_realistic_v3
[4] 2023: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2023_realistic_v2/120X_mcRun3_2023_realistic_v3
[5] 2024: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mcRun3_2024_realistic_v2/120X_mcRun3_2024_realistic_v3

PR validation:

runTheMatrix.py -l limited,11634.0,12434.0,12834.0 --ibeos -j8
tests pass

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport, and backport is not needed

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34450/23885

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jul 13, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4fe37/16726/summary.html
COMMIT: b916320
CMSSW: CMSSW_12_0_X_2021-07-12-1400/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34450/16726/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3607 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2787742
  • DQMHistoTests: Total failures: 2494
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785247
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 3 / 37 workflows

@francescobrivio
Copy link
Contributor

test parameters:

  • workflow = 12834.0

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4fe37/16734/summary.html
COMMIT: b916320
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34450/16734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3599 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2787742
  • DQMHistoTests: Total failures: 2493
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785249
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 3 / 37 workflows

@francescobrivio
Copy link
Contributor

@qliphy @silviodonato @perrotta we see a lot of failures in DQMHistoTests: Total failures: 2493
but they don't seem related to this PR, they seem to come from DQM TimerService

@mmusich
Copy link
Contributor

mmusich commented Jul 13, 2021

seems related to #34445

@smuzaffar
Copy link
Contributor

Not all of these diffs come from DQM/TimingService though

@mmusich
Copy link
Contributor

mmusich commented Jul 13, 2021

certainly all of the ones about

they seem to come from DQM TimerService

@francescobrivio
Copy link
Contributor

Not all of these diffs come from DQM/TimingService though

That's correct: some of them come from the new pixel bad components that we changed in the GTs, but it's a bit hard to exactly debug them among all the DQM TimerSevices failures.

@mmusich
Copy link
Contributor

mmusich commented Jul 13, 2021

That's correct: some of them come from the new pixel bad components that we changed in the GTs, but it's a bit hard to exactly debug them among all the DQM TimerSevices failures.

just to understand, will this PR be stalled until #34445 is solved?

@mmusich
Copy link
Contributor

mmusich commented Jul 13, 2021

@smuzaffar

some of them come from the new pixel bad components that we changed in the GTs

(just repeating what Francesco said)

@francescobrivio
Copy link
Contributor

test parameters:

  • workflow = 12834.0

@francescobrivio
Copy link
Contributor

@cmsbuild please test with #34464

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4fe37/16763/summary.html
COMMIT: b916320
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34450/16763/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3599 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2786302
  • DQMHistoTests: Total failures: 1702
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784578
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: found differences in 3 / 37 workflows

@malbouis
Copy link
Contributor

+alca

  • The GT differences show that the correct tags were updated
  • The differences in the comparison tests are in the expected workflows

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 14, 2021

+1

@cmsbuild cmsbuild merged commit a466af0 into cms-sw:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants