Run3-hcx301 Adopt the usage of ESGetToken in CaloTrkProcessing - one of the first SD's for Calo

[bsunanda]

PR description:

Adopt the usage of ESGetToken in CaloTrkProcessing - one of the first SD's for Calo

PR validation:

Use runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34451/23886

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34451/23886/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34451/23886/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34451/23887

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• SimG4CMS/Calo (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @thomreis, @felicepantaleo, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3baa7/16727/summary.html
COMMIT: 8d4f229
CMSSW: CMSSW_12_0_X_2021-07-12-1400/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34451/16727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2787742
• DQMHistoTests: Total failures: 871
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786871
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , regression problems accumulated uniformly over all tests. In each concrete test it is about 30. Not clear, why this happens. May be tests should be restarted again?

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3baa7/16794/summary.html
COMMIT: 8d4f229
CMSSW: CMSSW_12_0_X_2021-07-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34451/16794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786273
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[makortel]

This file (or at minimum this line) should be in plugins instead of src (as any other plugin definition). This is causing following job failures in CLANG IBs

----- Begin Fatal Exception 16-Jul-2021 01:20:57 CEST-----------------------
An exception of category 'WrongPluginLoaded' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=OscarMTProducer label='g4SimHits'
Exception Message:
The plugin 'CaloTrkProcessing' should have been loaded from
 '/cvmfs/cms-ib.cern.ch/nweek-02689/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_CLANG_X_2021-07-15-2300/lib/slc7_amd64_gcc900/pluginSimG4CMSCaloPlugins.so'
 but instead it was already loaded from
 '/cvmfs/cms-ib.cern.ch/nweek-02689/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_CLANG_X_2021-07-14-2300/lib/slc7_amd64_gcc900/pluginSimG4CMSTestBeamPlugins.so'
 because some other plugin was loaded from the latter loadables.
To work around the problem the plugin 'CaloTrkProcessing' should only be defined in one of these loadables.
----- End Fatal Exception -------------------------------------------------