Introduce L1TMuonBarrelKalmanParams and Record #34494

panoskatsoulis · 2021-07-14T22:55:09Z

Description
This PR introduces new Records and Objects required for implementing a primary "configuration from CondDB" for the L1 Kalman Barrel Emulator. There will be a follow up with the second part of development but this is the bare minimum for testing during the upcoming CRAFT and MWGRs.
The object L1TMuonBarrelKalmanParams holds some (not all yet) of the parameters required by the emulator.
(a static version of these params can be found here [1])
To be discussed during [2]
Validation
This code is validated locally, wrote and read to a local sqlite file
No Backport Needed

[1] https://github.com/cms-sw/cmssw/blob/master/L1Trigger/L1TMuonBarrel/python/simKBmtfDigis_cfi.py
[2] https://indico.cern.ch/event/1060075/#11-introduce-l1tmuonbarrelkalm

cmsbuild · 2021-07-14T22:55:30Z

@panoskatsoulis, CMSSW_12_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2021-07-14T23:02:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34494/23966

This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34494/23966/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34494/23966/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-07-14T23:22:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34494/23967

This PR adds an extra 60KB to repository

cmsbuild · 2021-07-14T23:23:06Z

A new Pull Request was created by @panoskatsoulis (Panos) for master.

It involves the following packages:

CondCore/L1TPlugins (db, l1)
CondFormats/DataRecord (db, alca)
CondFormats/L1TObjects (l1, db, alca)
L1Trigger/L1TMuonBarrel (l1)
L1TriggerConfig/Utilities (l1)

@malbouis, @yuanchao, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @Martin-Grunewald, @thomreis, @dinyar, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

panoskatsoulis · 2021-07-14T23:31:03Z

@rekovic this PR is moved to master (but still under the 12_0_X milestone) since "CMSSW_12_0_X branch is closed for direct updates" as the bot mentions above.
I don't know if it's a problem given that it's targeting the prereleases of CMSSW 12

perrotta · 2021-07-15T07:12:49Z

please test

cmsbuild · 2021-07-15T15:04:16Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/16838/summary.html
COMMIT: a1e3263
CMSSW: CMSSW_12_0_X_2021-07-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34494/16838/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 4 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/16838/llvm-analysis/esrget-sa.txt for details.
CMS StaticAnalyzer warnings: There are 2 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/16838/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2786302
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2786279
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

tvami · 2021-07-27T23:17:23Z

@cmsbuild , please test

tvami · 2021-07-27T23:18:20Z

unhold

Only Francesco can do that :) (and the release managers)

panoskatsoulis · 2021-07-27T23:23:24Z

unhold

Only Francesco can do that :) (and the release managers)

didn't know, thx

cmsbuild · 2021-07-28T02:46:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/17275/summary.html
COMMIT: 18bc00e
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34494/17275/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 4 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/17275/llvm-analysis/esrget-sa.txt for details.
CMS StaticAnalyzer warnings: There are 2 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/17275/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1299 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 3672
DQMHistoTests: Total nulls: 19
DQMHistoTests: Total successes: 2994851
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.703 KiB( 38 files compared)
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

francescobrivio · 2021-07-28T05:17:17Z

unhold

francescobrivio · 2021-07-28T06:09:39Z

+alca

differences are due to different files in step1 of wf 140.53

cecilecaillol · 2021-07-28T09:48:34Z

+l1

ggovi · 2021-07-28T12:08:42Z

+1

cmsbuild · 2021-07-28T12:09:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-07-28T14:22:46Z

L1TriggerConfig/Utilities/src/L1TMuonBarrelKalmanParamsViewer.cc

+  auto pnodes = ptr->pnodes_[ptr->CONFIG];
+  cout << "version    : " << ptr->version_ << endl;
+  cout << "fwVersion  : " << hex << pnodes.fwVersion_ << dec << endl;
+  cout << "LUTsPath   : " << pnodes.kalmanLUTsPath_ << endl;


std::cout is not threadsafe, please use https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMessageLogger

Hi, thanks for the notice about this
This module here is an L1T private tester and is not used in any central CMSSW workflow.
The purpose is to read 1 event (only) and print out the info included in the db Rcd
However, if it's required we can update it with MesageLogger in the next iteration of this development, is this fine?

@panoskatsoulis For the next iteration: if it is a private test, it shoud be better moved into the \test area?

Hi @perrotta, this is a good point
it is the entire pkg L1TriggerConfig/Utilities that contains these testing modules
Let me discuss this with the other L1 guys tho, thx

qliphy · 2021-07-28T14:25:38Z

@panoskatsoulis Please also have a look at
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/17275/llvm-analysis/legacy-mod-sa.txt
and
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd22a/17275/llvm-analysis/esrget-sa.txt

You can refer to e.g. #23743

panoskatsoulis · 2021-07-28T14:42:47Z

About these warnings,
I have put a comment above [1] and we keep in mind to apply patches in the next PR about this development.
Again these are about code that is not included in central WFs and if possible we would like to proceed with this PR for now and will fix them.

[1] #34494 (comment)

qliphy · 2021-07-28T15:20:04Z

ok, thanks @panoskatsoulis

qliphy · 2021-07-28T15:20:09Z

+1

panoskatsoulis added 5 commits July 7, 2021 12:22

added new L1TMuonBarrelKalmanParams and record

439cbf2

new KalmanParams ESProducer and static params config

9bb9e19

changes in the L1Config utilities, adapt Writer and upload config

053a393

added new kBmtf Viewer in the L1Config utils

5362863

new DataProxy plugin for L1TMuonBarrelKalmanParamsRcd

61a6883

cmsbuild changed the base branch from CMSSW_12_0_X to master July 14, 2021 22:55

cmsbuild added this to the CMSSW_12_0_X milestone Jul 14, 2021

cmsbuild added alca-pending code-checks-pending db-pending l1-pending orp-pending pending-signatures tests-pending labels Jul 14, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 14, 2021

code-checks fix

a1e3263

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 14, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 14, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 15, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 27, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 28, 2021

cmsbuild removed the hold label Jul 28, 2021

cmsbuild added alca-approved and removed alca-pending labels Jul 28, 2021

cmsbuild added l1-approved and removed l1-pending labels Jul 28, 2021

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jul 28, 2021

qliphy reviewed Jul 28, 2021

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Jul 28, 2021

cmsbuild merged commit bec73cc into cms-sw:master Jul 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce L1TMuonBarrelKalmanParams and Record #34494

Introduce L1TMuonBarrelKalmanParams and Record #34494

panoskatsoulis commented Jul 14, 2021 •

edited

cmsbuild commented Jul 14, 2021

cmsbuild commented Jul 14, 2021

cmsbuild commented Jul 14, 2021

cmsbuild commented Jul 14, 2021

panoskatsoulis commented Jul 14, 2021 •

edited

perrotta commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

tvami commented Jul 27, 2021

tvami commented Jul 27, 2021

panoskatsoulis commented Jul 27, 2021

cmsbuild commented Jul 28, 2021

francescobrivio commented Jul 28, 2021

francescobrivio commented Jul 28, 2021

cecilecaillol commented Jul 28, 2021

ggovi commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

qliphy Jul 28, 2021

panoskatsoulis Jul 28, 2021

perrotta Jul 28, 2021

panoskatsoulis Jul 29, 2021

qliphy commented Jul 28, 2021

panoskatsoulis commented Jul 28, 2021

qliphy commented Jul 28, 2021

qliphy commented Jul 28, 2021

Introduce L1TMuonBarrelKalmanParams and Record #34494

Introduce L1TMuonBarrelKalmanParams and Record #34494

Conversation

panoskatsoulis commented Jul 14, 2021 • edited

cmsbuild commented Jul 14, 2021

cmsbuild commented Jul 14, 2021

cmsbuild commented Jul 14, 2021

cmsbuild commented Jul 14, 2021

panoskatsoulis commented Jul 14, 2021 • edited

perrotta commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

Comparison Summary

tvami commented Jul 27, 2021

tvami commented Jul 27, 2021

panoskatsoulis commented Jul 27, 2021

cmsbuild commented Jul 28, 2021

Comparison Summary

francescobrivio commented Jul 28, 2021

francescobrivio commented Jul 28, 2021

cecilecaillol commented Jul 28, 2021

ggovi commented Jul 28, 2021

cmsbuild commented Jul 28, 2021

qliphy Jul 28, 2021

Choose a reason for hiding this comment

panoskatsoulis Jul 28, 2021

Choose a reason for hiding this comment

perrotta Jul 28, 2021

Choose a reason for hiding this comment

panoskatsoulis Jul 29, 2021

Choose a reason for hiding this comment

qliphy commented Jul 28, 2021

panoskatsoulis commented Jul 28, 2021

qliphy commented Jul 28, 2021

qliphy commented Jul 28, 2021

panoskatsoulis commented Jul 14, 2021 •

edited

panoskatsoulis commented Jul 14, 2021 •

edited