GEM unpacker - updated DAQ dataformat and new DAQ status collections #34504

jshlee · 2021-07-15T16:39:48Z

PR description:

DAQ dataformat is updated to the current version used in P5
GEM unpacked is changed to only produce digis when there are not DAQ errors
new DAQ status classes that checks for DAQ errors and stores it for OnlineDQM
run3 GE1/1 cannot read multi-BX, so by default non zero BX will not be unpacked for run3
added multi-BX mode for phase2
added plugin that checks if output the packing and unpacking is identical to the original simDigis
Discussed in the minutes of https://indico.cern.ch/event/1056074/#32-dpg
Link to presentation at GEM operations (https://indico.cern.ch/event/1058368/contributions/4448079/subcontributions/345162/attachments/2283335/3881798/gem_unpacker_20210719.pdf)

PR validation:

Validated with wf 11634.0 and 34611.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Will need to be backported to CMSSW_11_3_X for use on current cosmic runs

updated dataformats to latest version currently running

added GEMPackingTester

cmsbuild · 2021-07-15T16:48:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34504/23989

This PR adds an extra 104KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/GEMRawToDigi/plugins/GEMRawToDigiModule.cc modified in PR(s): Configurations and analyzer module to unpack and analyze B904 GEM trigger data #34478

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34504/23989/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34504/23989/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2021-07-15T17:33:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34504/23992

This PR adds an extra 220KB to repository

cmsbuild · 2021-07-15T17:34:19Z

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

CondFormats/GEMObjects (db)
DataFormats/GEMDigi (upgrade, simulation)
EventFilter/GEMRawToDigi (reconstruction)

@perrotta, @civanch, @mdhildreth, @cmsbuild, @jpata, @srimanob, @kpedro88, @slava77, @ggovi can you please review it and eventually sign? Thanks.
@rovere, @Martin-Grunewald, @watson-ij, @dildick, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

slava77 · 2021-07-15T18:15:03Z

@cmsbuild please test

jpata · 2021-07-21T10:18:18Z

+reconstruction

DAQ dataformat and tester update for GEM
differences in 10224.0 and 250202.181 are expected per GEM unpacker - updated DAQ dataformat and new DAQ status collections #34504 (comment)
no other reco differences

ggovi · 2021-07-21T12:15:59Z

+1

civanch · 2021-07-21T12:57:43Z

+1

srimanob · 2021-07-21T17:26:57Z

EventFilter/GEMRawToDigi/plugins/GEMPackingTester.cc

+          foundDigi = true;
+      }
+      if (!foundDigi) {
+        cout << "simMuonGEMDigi NOT found " << gemId << " " << digi->strip() << " " << digi->bx() << endl;


Use MessageLogger instead?
When this plugin is used actually? Just for private testing/debugging?

just for private debugging of the packing and unpacking process

srimanob · 2021-07-21T17:27:07Z

EventFilter/GEMRawToDigi/plugins/GEMPackingTester.cc

+      if (!foundDigi) {
+        cout << "simMuonGEMDigi NOT found " << gemId << " " << digi->strip() << " " << digi->bx() << endl;
+        for (auto unpackeddigi = packed.first; unpackeddigi != packed.second; ++unpackeddigi) {
+          cout << "rec " << unpackeddigi->strip() << " " << unpackeddigi->bx() << endl;


srimanob · 2021-07-21T17:30:53Z

EventFilter/GEMRawToDigi/test/gemUnPackerTester.py

+
+from Configuration.AlCa.GlobalTag import GlobalTag
+process.GlobalTag = GlobalTag(process.GlobalTag, '113X_mcRun4_realistic_v4', '')
+process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic_T21', '')


Why enable 2 GTs at once?
However, I assume no effect as this is under your test.

srimanob · 2021-07-22T06:21:39Z

+Upgrade

cmsbuild · 2021-07-22T06:22:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-07-22T06:42:20Z

+1

jshlee added 8 commits July 14, 2021 06:24

GEM new DAQ status data collections

1827039

updated dataformats to latest version currently running

added status collections

fe72ac6

added GEMPackingTester

removed phase2_GEM.toModify

0948054

code-checks

32cd651

added multiBX read for unpacking

7888412

packing testing

b3f4e4c

code-checks

6f5d41d

uncomment msg

ebc8605

cmsbuild added this to the CMSSW_12_0_X milestone Jul 15, 2021

cmsbuild added code-checks-pending db-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Jul 15, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 15, 2021

code-checks

da25054

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 15, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 15, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 15, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 21, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 21, 2021

cmsbuild added db-approved and removed db-pending labels Jul 21, 2021

cmsbuild added simulation-approved and removed simulation-pending labels Jul 21, 2021

srimanob reviewed Jul 21, 2021

View reviewed changes

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jul 22, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 22, 2021

cmsbuild merged commit 887ac84 into cms-sw:master Jul 22, 2021

qliphy mentioned this pull request Jul 22, 2021

[Backport] - GEM unpacker - updated DAQ dataformat and new DAQ status collections #34585

Merged

This was referenced Jul 22, 2021

Update python 3.9.6 cms-sw/cmsdist#7139

Closed

PPS geometry bug fix: missing file #34588

Merged

Updated root to tip of branch rootnext cms-sw/cmsdist#7160

Merged

quark2 mentioned this pull request Jul 24, 2021

Updates on GEM onlineDQM due to the updates of DAQ dataformat #34614

Merged

quark2 mentioned this pull request Aug 4, 2021

Updates on GEM onlineDQM due to the updates of DAQ dataformat, backport to CMSSW_11_3_X #34782

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEM unpacker - updated DAQ dataformat and new DAQ status collections #34504

GEM unpacker - updated DAQ dataformat and new DAQ status collections #34504

jshlee commented Jul 15, 2021 •

edited

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

slava77 commented Jul 15, 2021

jpata commented Jul 21, 2021

ggovi commented Jul 21, 2021

civanch commented Jul 21, 2021

srimanob Jul 21, 2021 •

edited

jshlee Jul 21, 2021

srimanob Jul 21, 2021

srimanob Jul 21, 2021

jshlee Jul 21, 2021

srimanob commented Jul 22, 2021

cmsbuild commented Jul 22, 2021

qliphy commented Jul 22, 2021

GEM unpacker - updated DAQ dataformat and new DAQ status collections #34504

GEM unpacker - updated DAQ dataformat and new DAQ status collections #34504

Conversation

jshlee commented Jul 15, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

cmsbuild commented Jul 15, 2021

slava77 commented Jul 15, 2021

jpata commented Jul 21, 2021

ggovi commented Jul 21, 2021

civanch commented Jul 21, 2021

srimanob Jul 21, 2021 • edited

Choose a reason for hiding this comment

jshlee Jul 21, 2021

Choose a reason for hiding this comment

srimanob Jul 21, 2021

Choose a reason for hiding this comment

srimanob Jul 21, 2021

Choose a reason for hiding this comment

jshlee Jul 21, 2021

Choose a reason for hiding this comment

srimanob commented Jul 22, 2021

cmsbuild commented Jul 22, 2021

qliphy commented Jul 22, 2021

jshlee commented Jul 15, 2021 •

edited

srimanob Jul 21, 2021 •

edited