-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate EDModules in RecoTauTag/RecoTau to esConsumes #34511
Conversation
0b0592b
to
5ab4166
Compare
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34511/24010
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c3eca/16875/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of #31061. I happened to look into these while we were updating the script producing the runTheMatrix-filtered list of EDModules that need to be migrated, and these looked straightforward-enough to migrate quickly. (and by the time we managed to get the script to handle properly the few "problematic" ones here, I had done majority of the work).
I intentionally left
TauDiscriminationAgainstCaloMuon
out because it looked like dead code (e.g. not using consumes for event data, nothing else in CMSSW referring to it).Resolves cms-sw/framework-team#191.
PR validation:
Code compiles