Run3-gex83C Convert one more SD (Hcal) to new format #34521

bsunanda · 2021-07-16T18:37:51Z

PR description:

Convert one more SD (Hcal) to new format and move the one for CaloTrkProcessing to plugins

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-07-16T18:45:10Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34521/24033

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34521/24033/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34521/24033/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-07-16T18:56:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34521/24035

This PR adds an extra 28KB to repository

cmsbuild · 2021-07-16T18:57:11Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimG4CMS/Calo (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @thomreis, @felicepantaleo, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-07-16T19:00:56Z

Please test

cmsbuild · 2021-07-16T23:19:54Z

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad88c/16927/summary.html
COMMIT: 59aa7b8
CMSSW: CMSSW_12_0_X_2021-07-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34521/16927/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 45124 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2786302
DQMHistoTests: Total failures: 195579
DQMHistoTests: Total nulls: 87
DQMHistoTests: Total successes: 2590614
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.318 KiB( 37 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.416 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -0.327 KiB SiStrip/MechanicalView
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: found differences in 9 / 37 workflows

bsunanda · 2021-07-17T00:29:28Z

@smuzaffar @qliphy @silviodonato @perrotta The unit failure is not linked with this PR. It is in the current IB against which it is tested. Could care be taken for that?

bsunanda · 2021-07-17T12:42:55Z

@cmsbuild Please test

cmsbuild · 2021-07-17T17:32:31Z

-1

Failed Tests: HeaderConsistency UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad88c/16942/summary.html
COMMIT: 59aa7b8
CMSSW: CMSSW_12_0_X_2021-07-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34521/16942/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 45124 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2786302
DQMHistoTests: Total failures: 195579
DQMHistoTests: Total nulls: 87
DQMHistoTests: Total successes: 2590614
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.318 KiB( 37 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.416 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -0.327 KiB SiStrip/MechanicalView
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: found differences in 9 / 37 workflows

civanch · 2021-07-19T07:54:04Z

please test

cmsbuild · 2021-07-19T12:32:34Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad88c/16973/summary.html
COMMIT: 43c16b2
CMSSW: CMSSW_12_0_X_2021-07-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34521/16973/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-6ad88c/11634.912_TTbar_14TeV+2021_DD4hepDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

No significant changes to the logs found
Reco comparison results: 45128 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2996268
DQMHistoTests: Total failures: 199220
DQMHistoTests: Total nulls: 88
DQMHistoTests: Total successes: 2796938
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.322 KiB( 38 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.416 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 7.3 ): -0.327 KiB SiStrip/MechanicalView
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 10 / 38 workflows

bsunanda · 2021-07-20T10:42:25Z

@cmsbuild Please test

bsunanda · 2021-07-21T01:08:20Z

@cmsbuild Please test

cmsbuild · 2021-07-21T08:46:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad88c/17036/summary.html
COMMIT: 43c16b2
CMSSW: CMSSW_12_0_X_2021-07-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34521/17036/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 47886 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2996268
DQMHistoTests: Total failures: 199222
DQMHistoTests: Total nulls: 87
DQMHistoTests: Total successes: 2796937
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.318 KiB( 38 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.542 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.117 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.416 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -0.327 KiB SiStrip/MechanicalView
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 10 / 38 workflows

civanch · 2021-07-21T09:20:59Z

SimG4CMS/Calo/plugins/module.cc

@@ -12,8 +11,6 @@

 typedef ECalSD EcalSensitiveDetector;
 DEFINE_SENSITIVEDETECTOR(EcalSensitiveDetector);
-typedef HCalSD HcalSensitiveDetector;


@bsunanda , where HCalSD is now?

HcalSensitiveDetectorBuilder instantiates HCalSD as HcalSensitiveDetector by supplying all objects needed from EventSetup

bsunanda · 2021-07-21T11:09:28Z

@civanch Please approve this. After it is integrated I can do this for other detectors in Calo

civanch · 2021-07-21T12:48:31Z

+1

cmsbuild · 2021-07-21T12:48:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-07-21T13:18:12Z

+1

Convert one more SD (Hcal) to new format

39e705e

cmsbuild added this to the CMSSW_12_0_X milestone Jul 16, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Jul 16, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 16, 2021

Code check

59aa7b8

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 16, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 16, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 17, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 17, 2021

cmsbuild added tests-started and removed tests-approved labels Jul 19, 2021

cmsbuild added tests-rejected and removed tests-started labels Jul 19, 2021

Dr15Jones mentioned this pull request Jul 19, 2021

Move CaloTrkProcessingBuilder.cc to plugins directory #34548

Closed

cmsbuild added tests-started and removed tests-rejected labels Jul 20, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 21, 2021

civanch reviewed Jul 21, 2021

View reviewed changes

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Jul 21, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 21, 2021

cmsbuild merged commit 9d63f03 into cms-sw:master Jul 21, 2021

This was referenced Jul 21, 2021

scram-tools repo to provide scram toolfile definitions cms-sw/cmsdist#7147

Merged

support global::OutputModule<ExternalWork> #34579

Merged

Remove EventSetup use from PdtEntry #34581

Merged

qliphy mentioned this pull request Jul 22, 2021

Unit failure on SimTracker/TrackerMaterialAnalysis #34587

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-gex83C Convert one more SD (Hcal) to new format #34521

Run3-gex83C Convert one more SD (Hcal) to new format #34521

bsunanda commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

bsunanda commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

bsunanda commented Jul 17, 2021

bsunanda commented Jul 17, 2021

cmsbuild commented Jul 17, 2021

civanch commented Jul 19, 2021

cmsbuild commented Jul 19, 2021

bsunanda commented Jul 20, 2021

bsunanda commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

civanch Jul 21, 2021

bsunanda Jul 21, 2021

bsunanda commented Jul 21, 2021

civanch commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

qliphy commented Jul 21, 2021

Run3-gex83C Convert one more SD (Hcal) to new format #34521

Run3-gex83C Convert one more SD (Hcal) to new format #34521

Conversation

bsunanda commented Jul 16, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

bsunanda commented Jul 16, 2021

cmsbuild commented Jul 16, 2021

Comparison Summary

bsunanda commented Jul 17, 2021

bsunanda commented Jul 17, 2021

cmsbuild commented Jul 17, 2021

Unit Tests

Comparison Summary

civanch commented Jul 19, 2021

cmsbuild commented Jul 19, 2021

Unit Tests

Comparison Summary

bsunanda commented Jul 20, 2021

bsunanda commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

Comparison Summary

civanch Jul 21, 2021

Choose a reason for hiding this comment

bsunanda Jul 21, 2021

Choose a reason for hiding this comment

bsunanda commented Jul 21, 2021

civanch commented Jul 21, 2021

cmsbuild commented Jul 21, 2021

qliphy commented Jul 21, 2021