Migrate module configuration in RecoJets to use default cfipython

[jeongeun]

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations. (The previous PRs : #33207, #33307, #33352, #33543, #33563, #33671, #34007, #34091, #34009, #34155, #34371, #34480)

In this PR, 3 files changed.
modified: RecoJets/JetProducers/python/ak4PFJetsBetaStar_cfi.py
modified: RecoJets/JetProducers/python/hltMVAJetPuId_cff.py
modified: RecoJets/JetProducers/python/hltak4CaloJets_cfi.py

Update

• Replace explicit configuration with a reference from cfipython/. (migrating EDProducer("type", .. -> typeDefaylt.clone() )
• Remove the type specifications already presented in cfipython/fillDescriptions reference for improved syntax safety.
• Remove the duplicated parameters that are exactly the same value in cfipython reference.

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_0_X, the basic test all passed in the CMSSW PR instructions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34543/24066

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• RecoJets/JetProducers (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @yslai, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: Build Python3
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-267e19/16968/summary.html
COMMIT: f5ca4f0
CMSSW: CMSSW_12_0_X_2021-07-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34543/16968/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

#Python3

I found errors:

*** Error compiling 'src/RecoJets/JetProducers/python/hltak4CaloJets_cfi.py'...

[jpata]

Suggested change

	import RecoJets.JetProducers.FastjetJetProducer_cfi _mod
	import RecoJets.JetProducers.FastjetJetProducer_cfi as _mod

[jpata]

Thanks for this! Can you double check the syntax error above? Also, could you check if the validations were affected by this error?

[perrotta]

Thanks for this! Can you double check the syntax error above? Also, could you check if the validations were affected by this error?

Yes, the python3 error reported in the tests was due exactly to the typo you pointed out

[jpata]

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_0_X, the basic test all passed in the CMSSW PR instructions.

right, I mean to double check if the validations done in the PR description are up to date with what was committed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34543/24116

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #34543 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-267e19/17040/summary.html
COMMIT: f12f4bf
CMSSW: CMSSW_12_0_X_2021-07-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34543/17040/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2996245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical
• no reco differences expected/observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1