HCAL: HF ShowerLibrary combining code/script update

[abdoulline]

PR description:

Minor update, which wasn't included in the previous PR #34500

PR validation:

Validated locally, the code and job config aren't used in regular wf's

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34561/24094

ERROR: Build errors found during clang-tidy run.

SimG4CMS/ShowerLibraryProducer/plugins/HcalForwardLibWriter.cc:51:13: error: variable-sized object may not be initialized [clang-diagnostic-error]
    float x[nshowers] = {0.};
            ^
SimG4CMS/ShowerLibraryProducer/plugins/HcalForwardLibWriter.cc:52:13: error: variable-sized object may not be initialized [clang-diagnostic-error]
    float y[nshowers] = {0.};
            ^
SimG4CMS/ShowerLibraryProducer/plugins/HcalForwardLibWriter.cc:53:13: error: variable-sized object may not be initialized [clang-diagnostic-error]
    float z[nshowers] = {0.};
            ^
SimG4CMS/ShowerLibraryProducer/plugins/HcalForwardLibWriter.cc:54:13: error: variable-sized object may not be initialized [clang-diagnostic-error]
    float t[nshowers] = {0.};
            ^
SimG4CMS/ShowerLibraryProducer/plugins/HcalForwardLibWriter.cc:55:18: error: variable-sized object may not be initialized [clang-diagnostic-error]
    float lambda[nshowers] = {0.};
                 ^
SimG4CMS/ShowerLibraryProducer/plugins/HcalForwardLibWriter.cc:56:17: error: variable-sized object may not be initialized [clang-diagnostic-error]
    int fiberId[nshowers] = {0};
                ^
Suppressed 1451 warnings (1450 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34561/24096

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

• SimG4CMS/ShowerLibraryProducer (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c75a85/17016/summary.html
COMMIT: 70d9d29
CMSSW: CMSSW_12_0_X_2021-07-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34561/17016/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2996239
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1