New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge .h and .cc files of plugins in several PhysicsTools packages #34594
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34594/24151
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages:
@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: RelVals CMS StaticAnalyzer warnings: There are 2 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c19dca/17104/llvm-analysis/esrget-sa.txt for details. RelVals
|
@cmsbuild please test |
-1 Failed Tests: RelVals-INPUT CMS StaticAnalyzer warnings: There are 2 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c19dca/17123/llvm-analysis/esrget-sa.txt for details. RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c19dca/17176/summary.html CMS StaticAnalyzer warnings: There are 2 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c19dca/17176/llvm-analysis/esrget-sa.txt for details. Comparison SummarySummary:
|
+reconstruction for #34594 de74f55
|
Thanks! @qliphy, I think this can be merged without waiting for the analysis signoff which is usually just a simple +1 anyway. |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Part of the series of PRs that merges
.h
files with the.cc
files of the plugins in the PhysicsTools subsystem, continuing what was started in #34307.It makes maintaining the plugins much easier and also excludes the possibility to wrongly include plugin header files.
There were the steps taken to merge the files:
PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.