HCAL: fine grain bits for timing and depth LLP trigger set

[gk199]

PR description:

Sets 6 fine grain bits in HB and HE based on TDC and amplitude, in agreement with the uHTR firmware implementation 2.5.0. 6 bits are set per trigger tower: bit[0] depth / amplitude based, bit[1] and bit[2] reserved MIP bits, bit[3] indicates a prompt cell, bit[4] indicates a slightly delayed cell, bit[5] indicates a very delayed cell. These fine grain bits will be used in the HCAL L1 delayed/displaced jet trigger, to capture LLP decays.

The compute function in HcalFinegrainBit is modified to take an array of TDC and ADC values from a tower, and returns 6 bits. Two bits from the initial compute function are saved as the 2 reserved MIP bits. In HcalTriggerPrimitiveAlgo, a container and map to store the TDC and ADC per tower are created, and filled in the new function addUpgradeTDCFG. This map is passed as an argument to compute.

DocDB with uHTR and fine-grain bit specifications: https://cms-docdb.cern.ch/cgi-bin/PublicDocDB/RetrieveFile?docid=12306&filename=LLPbits_uhtr_spec.pdf&version=21

PR validation:

Passed runTheMatrix.py test. Tested in CMSSW_12_0_X.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34600/24161

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34600/24161/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34600/24161/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34600/24162

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @gk199 (Gillian Kopp) for master.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimAlgos (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

@gk199 Gillian, I'd suggest :

• to modify the title, to smth. more laconic "HCAL: fine grain bits for timing and depth LLP trigger set"
• to remove from the introduction/preamble 5 lines starting from "if this PR is a backport please specify..."

[gk199]

@gk199 Gillian, I'd suggest :

• to modify the title, to smth. more laconic "HCAL: fine grain bits for timing and depth LLP trigger set"
• to remove from the introduction/preamble 5 lines starting from "if this PR is a backport please specify..."

Thanks Salavat, I made these edits now

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d6565/17192/summary.html
COMMIT: e1a78f6
CMSSW: CMSSW_12_0_X_2021-07-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34600/17192/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 52
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998489
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1