New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up the CSC trigger emulator for Run-3 and Phase-2 #34638
Speed up the CSC trigger emulator for Run-3 and Phase-2 #34638
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34638/24226
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages:
@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@makortel Can you start the tests? |
@cmsbuild, please test |
urgent |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34a36e/17224/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Issue #34633 reports a significant slowdown in cmsRun calls in recent IBs, pointing to the startup of the CSC trigger emulator code. A large number of LUTs need to be loaded. A solution is being considered at the moment. In the mean time, I will hide certain LUTs behind if statements. LUTs are then only loaded when an expert flag is set. This should prevent these LUTs from being loaded for now:
GEM-CSC LUTs in folder L1Trigger/CSCTriggerPrimitives/data/GEMCSC/ are unfortunately still being loaded for each ME1/1 chamber. Other than turning off the GEM-CSC trigger itself, I don't have a prompt solution.
A longer term solution may be the introduction of ESProducer and ESProduct objects for CSC lookup tables. To be discussed with CSC DPG.
PR validation:
Code compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: