FireWorks: Fix clang-tidy boost-use-to-string warnings and boost header

[smuzaffar]

clang-tidy boost-use-to-string check generated around 120 wranings about

Fireworks/Calo/plugins/FWEcalRecHitProxyBuilder.cc:33:1: warning: use std::to_string instead of boost::lexical_cast<std::string> [boost-use-to-string]
REGISTER_FWPROXYBUILDER(FWEcalRecHitProxyBuilder, EcalRecHitCollection, "Ecal RecHit", FWViewType::kISpyBit);

but it does not fix these as in this case the code is in a macro. This PR proposes to use std::to_string() instead of boost::lexical_cast<std::string>

There are also many warnings about deprecated boost header. This PR also fixes this and uses boost/test/unit_test.hpp instead

>> Compiling edm plugin Fireworks/Tracks/plugins/FWTracksModulesProxyBuilder.cc
In file included from boost/config/header_deprecated.hpp:18,
                 from boost/test/auto_unit_test.hpp:16,
                 from boost/1.75.0-d9c5ee2ea4b2d631c2076f2838e5d91a/include/boost/test/auto_unit_test.hpp:17:1: note: #pragma message: This header is deprecated. Use <boost/test/unit_test.hpp> instead.
   17 | BOOST_HEADER_DEPRECATED( "<boost/test/unit_test.hpp>" )
      | ^~~~~~~~~~~~~~~~~~~~~~~

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34656/24265

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34656/24265/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34656/24265/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34656/24267

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Fireworks/Core (visualization)

@makortel, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[alja]

+1
Thank You!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0f8f4/17268/summary.html
COMMIT: 8782fd7
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34656/17268/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1304 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 3677
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2994845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.699 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[qliphy]

+1