Fix uploading EventSetup conditions from multiple CUDA streams [12.0.x] #34730
Conversation
When multiple CUDA streams are trying to initialise the same EventSetup object, the first one to do so starts the asynchronous operations, and the others are supposed to wait for it to finish. However, code for recording the CUDA event was missing, so the other streams would find the default- constructed event, which is always "valid". Adding the missing call to record the event fixes the problem.
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_0_X. It involves the following packages:
@makortel, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
backport of #34725 |
|
type bugfix |
|
please test |
|
+heterogeneous |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
heterogeneous-approved
and removed
heterogeneous-pending
pending-signatures
labels
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
|
+1 |
|
merge |
PR description:
When multiple CUDA streams are trying to initialise the same EventSetup object, the first one to do so starts the asynchronous operations, and the others are supposed to wait for it to finish. However, code for recording the CUDA event was missing, so the other streams would find the default- constructed event, which is always "valid".
Adding the missing call to record the event fixes the problem.
PR validation:
See #34725 .
PR status:
Backport of #34725 to
CMSSW_12_0_X.