Run3-hcx306X Bug fix (backport #34738) to HCAL SD class

[bsunanda]

PR description:

Bug fix (backport of #34738) to HCAL SD class

PR validation:

Tested for some of the standard workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #34738

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_12_0_X.

It involves the following packages:

• SimG4CMS/Calo (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@cvuosalo, @rovere, @thomreis, @felicepantaleo, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx306 Bug fix to get back the same hit energy distribution for HCAL #34738

[civanch]

please test

[civanch]

type bugfix

[perrotta]

backport of #34738

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ccc9f/17478/summary.html
COMMIT: ef56caa
CMSSW: CMSSW_12_0_X_2021-08-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34747/17478/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11604.011604.0_SingleGammaPt10+2021+SingleGammaPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleGammaPt10+2021+SingleGammaPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11634.011634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11602.0
• 11601.0
• 11605.0
• 11606.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.13
• 11834.24
• 11846.0
• 11925.0
• 12034.0
• 12434.0
• 12634.0
• 12834.0
• 13034.0
• 23434.21
• 23434.99
• 23434.9921
• 34834.9921
• 34834.21

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 48883 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 198387
• DQMHistoTests: Total nulls: 87
• DQMHistoTests: Total successes: 2800068
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.28 KiB( 38 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.368 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.410 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.234 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 13 / 38 workflows

[perrotta]

@cms-sw/simulation-l2 please don't care for your evaluation about the failed RelVals-INPUT tests: they are linked to #34633, and not expected to be fixed so soon
Just stick on the other tests and comparisons

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge