Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization of several simulation standalone test EDAnalyzers #34754

Merged
merged 7 commits into from Aug 5, 2021

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Aug 4, 2021

PR description:

This PR proposes the modernization of several standalone analyzers for simulation test. None of them is part of production workflows, so they have been all moved to a edm::one::EDAnalyzer type. The input collections and test configurations have been updated accordingly.

PR validation:

Tested to run on the output of wfs 11607 and 34607 in recent 12_1_X IBs. The PR test will just probe code compilation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34754/24420

  • This PR adds an extra 32KB to repository

@fabiocos
Copy link
Contributor Author

fabiocos commented Aug 4, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • IOMC/EventVertexGenerators (simulation)
  • PhysicsTools/HepMCCandAlgos (analysis)
  • SimG4Core/Application (simulation)
  • SimGeneral/Debugging (simulation)

@civanch, @santocch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @jan-kaspar, @rovere, @bsunanda, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ca7fd/17503/summary.html
COMMIT: eaab48d
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34754/17503/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998541
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Aug 4, 2021

+1

This PR is inlined with recent design change requirement.

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

+1

  • @cms-sw/analysis-l2 this modernizes a few analyzers and scripts in test areas

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2021

merge

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants