-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Geometry] Move public headers to interface directory #34755
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,15 +10,15 @@ | |
// Modified: Wed, 23 December 2020 | ||
// Original author: Tim Cox | ||
*/ | ||
#include "CSCGeometryParsFromDD.h" | ||
#include "../interface/CSCGeometryParsFromDD.h" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @smuzaffar - and here? |
||
#include "DetectorDescription/Core/interface/DDFilteredView.h" | ||
#include "DetectorDescription/Core/interface/DDSolid.h" | ||
#include "Geometry/CSCGeometry/interface/CSCChamberSpecs.h" | ||
#include "Geometry/MuonNumbering/interface/CSCNumberingScheme.h" | ||
#include "Geometry/MuonNumbering/interface/MuonBaseNumber.h" | ||
#include "Geometry/MuonNumbering/interface/MuonGeometryNumbering.h" | ||
#include "Geometry/MuonNumbering/interface/MuonGeometryConstants.h" | ||
#include "Geometry/CSCGeometry/src/CSCWireGroupPackage.h" | ||
#include "Geometry/CSCGeometry/interface/CSCWireGroupPackage.h" | ||
#include "CondFormats/GeometryObjects/interface/CSCRecoDigiParameters.h" | ||
#include "CondFormats/GeometryObjects/interface/RecoIdealGeometry.h" | ||
#include "FWCore/MessageLogger/interface/MessageLogger.h" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
#include "Geometry/CaloGeometry/interface/CaloCellGeometry.h" | ||
#include "Geometry/ForwardGeometry/interface/ZdcGeometry.h" | ||
#include "Geometry/ForwardGeometry/interface/IdealZDCTrapezoid.h" | ||
#include "ZdcHardcodeGeometryData.h" | ||
#include "../interface/ZdcHardcodeGeometryData.h" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @smuzaffar - and here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as codeing rules ( http://cms-sw.github.io/cms_coding_rules.html#6--packaging-rules-1 ) permit this so that is why I used it but I can fix this and replace it with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 4.8 Do not use absolute directory names or relative file paths in #include directives. |
||
#include <algorithm> | ||
|
||
typedef CaloCellGeometry::CCGFloat CCGFloat; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smuzaffar - is it intended?