New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCAL] From CaloParticle to SimTrackster in the Validation linking section #34800
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34800/24517
|
A new Pull Request was created by @lecriste (Leonardo Cristella) for master. It involves the following packages:
@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @ahmad3213, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: RelVals RelVals
Expand to see more relval errors ... |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34800/24529
|
Pull request #34800 was updated. @perrotta, @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @ahmad3213, @slava77, @jpata, @rvenditti can you please check and sign again. |
@cmsbuild please test |
if you are referring to the RelVals-INPUT list in #34800 (comment); I think that these were appearing in other PR tests a couple of days ago but were gone since about a day. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b5b4e/17763/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction
|
@srimanob, can you please review this PR? |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@lecriste @slava77 do I understand correctly that the randomness discussed above is the responsible of the differences we see in the jenkins tests for Are those random differences expected to disappear after #34858 is merged? |
PR description:
This PR replaces the CaloParticle collection with a dedicated SimTrackster collection, in the HGCAL Validation section of the Tracksters linking to Sim objects.
No changes are expected in the output, except for some unchanged histograms moved to a new DQM subfolder.
PR validation:
runTheMatrix -l limited