Run3-alca192B Change std::cout to edm::LogVerbatim in a number of classes in Calibration/IsolatedParticles #34823

bsunanda · 2021-08-09T16:08:08Z

PR description:

Change std::cout to edm::LogVerbatim in a number of classes in Calibration/IsolatedParticles

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

…ration/IsolatedParticles

cmsbuild · 2021-08-09T16:16:31Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34823/24590

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34823/24590/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34823/24590/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-08-09T16:25:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34823/24591

This PR adds an extra 28KB to repository

cmsbuild · 2021-08-09T16:26:13Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/IsolatedParticles (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-08-09T16:34:32Z

@cmsbuild Please test

cmsbuild · 2021-08-09T21:10:41Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734806/17651/summary.html
COMMIT: 28991f0
CMSSW: CMSSW_12_1_X_2021-08-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34823/17651/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11634.511634.5_TTbar_14TeV+2021_pixelTrackingOnly+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST/step2_TTbar_14TeV+2021_pixelTrackingOnly+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999410
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2999387
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

bsunanda · 2021-08-09T21:18:32Z

@cmsbuild Please test

cmsbuild · 2021-08-10T03:08:25Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734806/17653/summary.html
COMMIT: 28991f0
CMSSW: CMSSW_12_1_X_2021-08-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34823/17653/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999410
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2999381
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

bsunanda · 2021-08-10T13:46:46Z

@cmsbuild Please test

bsunanda · 2021-08-10T14:38:05Z

@francescobrivio, @TVAM, @perrotta, @qliphy The failures in the test are not due to this PR. The same failure happens for a number of PR's

francescobrivio · 2021-08-11T07:02:00Z

+alca

Failures in RelVals-INPUT have been observed in many PR recently and not related to this PR

cmsbuild · 2021-08-11T07:02:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-08-11T08:53:21Z

+1

qliphy · 2021-08-11T08:53:27Z

merge

cmsbuild · 2021-08-11T22:57:05Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734806/17689/summary.html
COMMIT: 28991f0
CMSSW: CMSSW_12_1_X_2021-08-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34823/17689/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11834.2411834.24_TTbar_14TeV+2021PU_0T+TTbar_14TeV_TuneCP5_GenSimINPUT+DigiPU+RecoPU+HARVESTPU+Nano/step2_TTbar_14TeV+2021PU_0T+TTbar_14TeV_TuneCP5_GenSimINPUT+DigiPU+RecoPU+HARVESTPU+Nano.log
23434.2123434.21_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU/step2_TTbar_14TeV+2026D49PU_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTriggerPU+RecoGlobalPU+MiniAODPU.log
23434.9923434.99_TTbar_14TeV+2026D49PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2999420
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2999391
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

change std::cout to edm::LLogVerbatim in a number of classes in Calib…

f7b5347

…ration/IsolatedParticles

cmsbuild added this to the CMSSW_12_1_X milestone Aug 9, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Aug 9, 2021

bsunanda changed the title ~~Run3-alca192B Change std::cout to edm::LLogVerbatim in a number of classes in Calibration/IsolatedParticles~~ Run3-alca192B Change std::cout to edm::LogVerbatim in a number of classes in Calibration/IsolatedParticles Aug 9, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 9, 2021

Code check

28991f0

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 9, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 9, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 9, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 9, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 10, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 10, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Aug 11, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 11, 2021

cmsbuild merged commit 55b543e into cms-sw:master Aug 11, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca192B Change std::cout to edm::LogVerbatim in a number of classes in Calibration/IsolatedParticles #34823

Run3-alca192B Change std::cout to edm::LogVerbatim in a number of classes in Calibration/IsolatedParticles #34823

bsunanda commented Aug 9, 2021 •

edited

cmsbuild commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

bsunanda commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

bsunanda commented Aug 9, 2021

cmsbuild commented Aug 10, 2021

bsunanda commented Aug 10, 2021

bsunanda commented Aug 10, 2021

francescobrivio commented Aug 11, 2021

cmsbuild commented Aug 11, 2021

qliphy commented Aug 11, 2021

qliphy commented Aug 11, 2021

cmsbuild commented Aug 11, 2021

Run3-alca192B Change std::cout to edm::LogVerbatim in a number of classes in Calibration/IsolatedParticles #34823

Run3-alca192B Change std::cout to edm::LogVerbatim in a number of classes in Calibration/IsolatedParticles #34823

Conversation

bsunanda commented Aug 9, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

bsunanda commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

RelVals-INPUT

Comparison Summary

bsunanda commented Aug 9, 2021

cmsbuild commented Aug 10, 2021

RelVals-INPUT

Comparison Summary

bsunanda commented Aug 10, 2021

bsunanda commented Aug 10, 2021

francescobrivio commented Aug 11, 2021

cmsbuild commented Aug 11, 2021

qliphy commented Aug 11, 2021

qliphy commented Aug 11, 2021

cmsbuild commented Aug 11, 2021

RelVals-INPUT

Comparison Summary

bsunanda commented Aug 9, 2021 •

edited