Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add commissioning_run as runType and use it in SiStrip online DQM client [11.3.X] #34838

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 11, 2021

backport of #34832

PR description:

This PR adds a new DQM runType commissioning_run in order to define a new clause in the SiStrip online client to be used when there are no physics triggers.

PR validation:

at the moment none. to be further tested

if this PR is a backport please specify the original PR and why you need to backport that PR:

Original PR: #34832, to be tested in CRUZET 2021 data-taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_3_X.

It involves the following packages:

  • DQM/Integration (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f154f4/17693/summary.html
COMMIT: ad40012
CMSSW: CMSSW_11_3_X_2021-08-08-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34838/17693/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1275 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2878314
  • DQMHistoTests: Total failures: 3672
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 2874600
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 45.699 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

We would like to test this at P5 in Online DQM, however we believe it is better to have a commissioning_run to do a proper test

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2021

Is this still relevant at all, or should rather a 12.0.x backport be opened?

@jfernan2
Copy link
Contributor

It depends on the version to be used at commissioning_run test. At present we are moving Online DQM at P5 to 12.0.X so, yes please make at backport to 12.0.X
Thank you!!

@perrotta
Copy link
Contributor

-1

  • Reprocessing of CRUZET data already started with 11_3, and all online deta taking related operations will move to 12_0: no need to merge anything else in 11_3, as discussed and decided in the 21/09 ORP meeting

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2021

-1

  • Reprocessing of CRUZET data already started with 11_3, and all online deta taking related operations will move to 12_0: no need to merge anything else in 11_3, as discussed and decided in the 21/09 ORP meeting

fine... moved it to #35365

@mmusich mmusich closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants