Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_0_X] Backport the fix on the workflow 537 and the mergeLHE.py script #34861

Merged

Conversation

colizz
Copy link
Contributor

@colizz colizz commented Aug 13, 2021

PR description:

Backport of

  1. 2e7e1c0 in Enable concurrent GEN in Configuration/Generator/python #34710
  2. Fix the mergeLHE.py script #34804

The first helps to fix the workflow 537 in the 4-thread mode. The issue is identified in #34531. The error is caused by a physics issue in the generator meaning that generating merely 2 events may probabilistically cause zero x-section.

The second is a relevant fix to make the mergeLHE.py script more generalized (the script is called in workflow 537), as also discussed in #34531.

PR validation:

Workflow 537 works in the 4-thread mode.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 13, 2021

A new Pull Request was created by @colizz (Congqiao Li) for CMSSW_12_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • GeneratorInterface/LHEInterface (generators)

@SiewYan, @mkirsano, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @agrohsje, @kpedro88, @kskovpen, @alberto-sanchez, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@mkirsano, @makortel, @Martin-Grunewald, @alberto-sanchez, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #34804
(partial) backport of #34710

@perrotta
Copy link
Contributor

type bug fix

@agrohsje
Copy link

test parameters:
workflow_threading = 537.0
enable_test = threading

@agrohsje
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac9eca/17832/summary.html
COMMIT: b001a8c
CMSSW: CMSSW_12_0_X_2021-08-17-1100/slc7_amd64_gcc900
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34861/17832/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@agrohsje
Copy link

+generators

@qliphy
Copy link
Contributor

qliphy commented Aug 20, 2021

kindly ping @cms-sw/pdmv-l2 @cms-sw/upgrade-l2

@kskovpen
Copy link
Contributor

+1

@qliphy
Copy link
Contributor

qliphy commented Aug 23, 2021

ping @cms-sw/upgrade-l2

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 26, 2021

+1

@cmsbuild cmsbuild merged commit f8a13ae into cms-sw:CMSSW_12_0_X Aug 26, 2021
colizz added a commit to colizz/cmssw that referenced this pull request Aug 30, 2021
Backport of cms-sw#34710.
Note that the requested events for workflow 537 has modified prior than this PR in cms-sw#34861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants