Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include in CondDBTools.cc #34869

Merged
merged 1 commit into from Aug 13, 2021
Merged

Add missing include in CondDBTools.cc #34869

merged 1 commit into from Aug 13, 2021

Conversation

iarspider
Copy link
Contributor

PR description:

Build log: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_12_1_X_2021-08-13-1100/CondCore/Utilities

Error message:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/6832eed357397f6b862ceadce6a298f6/opt/cmssw/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_1_X_2021-08-13-1100/src/CondCore/Utilities/src/CondDBTools.cc: In function 'size_t cond::persistency::importIovs(const string&, cond::persistency::Session&, const string&, cond::persistency::Session&, cond::Time_t, cond::Time_t, const string&, const string&, bool, bool, bool)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/6832eed357397f6b862ceadce6a298f6/opt/cmssw/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_1_X_2021-08-13-1100/src/CondCore/Utilities/src/CondDBTools.cc:97:12: error: 'set' is not a member of 'std'
    97 |       std::set<cond::Hash> pids;
      |            ^~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/6832eed357397f6b862ceadce6a298f6/opt/cmssw/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_1_X_2021-08-13-1100/src/CondCore/Utilities/src/CondDBTools.cc:4:1: note: 'std::set' is defined in header '<set>'; did you forget to '#include <set>'?
    3 | #include "CondCore/CondDB/interface/ConnectionPool.h"
  +++ |+#include <set>
    4 | //

Only affects CMSSW_12_1_X for some reason

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34869/24672

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • CondCore/Utilities (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

Please test

@Dr15Jones
Copy link
Contributor

@smuzaffar do we know which pull request broke the IB and how our tests missed it?

@Dr15Jones
Copy link
Contributor

It looks like it was these two pull requests

#34847
#34826

where the latter was tested in an IB that existed before the former was merged into the master.

@smuzaffar
Copy link
Contributor

thats correct @Dr15Jones , combination of #34847 and #34826 caused this issue.
@qliphy , @perrotta, this is trivial technical fix. I would suggest to merge it so that we can start a new working IB

@qliphy
Copy link
Contributor

qliphy commented Aug 13, 2021

merge

@cmsbuild cmsbuild merged commit 1644d7b into cms-sw:master Aug 13, 2021
@smuzaffar
Copy link
Contributor

thanks @qliphy, I have started 17h00 IB.

@iarspider iarspider deleted the patch-8 branch August 13, 2021 16:14
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55d01b/17766/summary.html
COMMIT: e346f3f
CMSSW: CMSSW_12_1_X_2021-08-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34869/17766/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55d01b/17766/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55d01b/17766/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001486
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3001457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.736 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 1325.81,... ): 0.870 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants