Follow up to PR review of CPEFast to better reproduce Generic and #34400

[czangela]

PR description:

This PR should address the remaining issues in #34400 .

1. Add reference to "plot"
2. Replace a few magic numbers
3. Reduce repeated computations.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34882/24690

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @czangela for master.

It involves the following packages:

• Geometry/TrackerGeometryBuilder (geometry)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@tvami, @fabiocos, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bsunanda, @OzAmram, @ferencek, @mtosi, @gpetruc, @mmusich, @dkotlins, @threus, @dgulhan, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79241e/17788/summary.html
COMMIT: 11f56a7
CMSSW: CMSSW_12_1_X_2021-08-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34882/17788/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000323
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[slava77]

Suggested change

	constexpr int GenErrorQBins = 5;
	// arbitrary number of bins for sampling errors
	constexpr int NumErrorBins = 16;
	constexpr int kGenErrorQBins = 5;
	// arbitrary number of bins for sampling errors
	constexpr int kNumErrorBins = 16;

• start local variables and data members with lower case letter. Capitalization is reserved for class names.
• Also, a somewhat recent rule for constants http://cms-sw.github.io/cms_coding_rules.html#2--naming-rules-1 2.17 (this one is up for debate for this code, considering the style for other constants in the related code are likely to be the exception to this rule).

[slava77]

Suggested change

using namespace CPEFastParametrisation;

using namespace is not allowed in the header files

[slava77]

@czangela
please clarify on the status of updates in this PR, following the code review in #34882 (review)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34882/24840

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #34882 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @jpata can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79241e/17989/summary.html
COMMIT: 6bc85e6
CMSSW: CMSSW_12_1_X_2021-08-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34882/17989/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34882 6bc85e6

• code changes are technical, they are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1