Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate AlignmentProducer to event consumes #34885

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 16, 2021

PR description:

Title says it all, migrate AlignmentProducer to event consumes, as it is already done for AlignmentProducerAsAnalyzer.cc

tjTkAssociationMapToken_ = consumes<TrajTrackAssociationCollection>(tjTkAssociationMapTag_);
beamSpotToken_ = consumes<reco::BeamSpot>(beamSpotTag_);
tkLasBeamToken_ = consumes<TkFittedLasBeamCollection>(tkLasBeamTag_);
tsosVectorToken_ = consumes<TsosVectorCollection>(tkLasBeamTag_);
clusterValueMapToken_ = consumes<AliClusterValueMap>(clusterValueMapTag_);

PR validation:

Run unit tests scram b runtests also using Alignment/TrackerAlignment package.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Will need to be backported to support HipPy alignment algorithm.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34885/24695

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Aug 16, 2021

test parameters:

  • addpkg = Alignment/TrackerAlignment

@mmusich
Copy link
Contributor Author

mmusich commented Aug 16, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ae3bf/17797/summary.html
COMMIT: a7f22d3
CMSSW: CMSSW_12_1_X_2021-08-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34885/17797/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000323
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 18, 2021

tested successfully with this configuration file.

@mmusich mmusich marked this pull request as ready for review August 18, 2021 19:48
@tvami
Copy link
Contributor

tvami commented Aug 18, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5da88e0 into cms-sw:master Aug 19, 2021
@mmusich mmusich deleted the Alignment/CommonAlignmentProducer_migrateToConsumes branch August 19, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants