Remove unused headers for CommonTools packages

[yuanchao]

PR description:

Remove unused header for packages #3

Following the issue #31505, the following headers are unused in CommonTools package:

• CommonTools/CandAlgos/interface/CloneProducer.h
• CommonTools/CandUtils/interface/CandMatcher.h
• CommonTools/CandUtils/interface/FastCandMatcher.h
• CommonTools/CandUtils/interface/NamedCandCombiner.h
• CommonTools/ParticleFlow/interface/ObjectSelector.h
• CommonTools/ParticleFlow/interface/ObjectSelectors.h
• CommonTools/Statistics/interface/BinomialProbability.h
• CommonTools/UtilAlgos/interface/DummyMatchSelector.h
• CommonTools/UtilAlgos/interface/MassMinSelector.h
• CommonTools/UtilAlgos/interface/MassRangeSelector.h
• CommonTools/UtilAlgos/interface/MinSelector.h
• CommonTools/UtilAlgos/interface/ObjectPairFilter.h
• CommonTools/UtilAlgos/interface/ObjectRefVectorSelector.h
• CommonTools/UtilAlgos/interface/OrPairSelector.h
• CommonTools/Utils/interface/Angle.h
• CommonTools/Utils/interface/InvariantMass.h
• CommonTools/Utils/interface/LazyResult.h
• CommonTools/Utils/interface/MassMinSelector.h
• CommonTools/Utils/interface/MassRangeSelector.h
• CommonTools/Utils/interface/MinSelector.h
• CommonTools/Utils/interface/OrPairSelector.h

This is the third batch of the unused header removal.

PR validation:

Code compiles. Run local limited runTheMatrix.py tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport forseen

[cmsbuild]

@yuanchao, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24697

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

• CommonTools/CandAlgos (reconstruction)
• CommonTools/CandUtils (reconstruction)
• CommonTools/ParticleFlow (reconstruction)
• CommonTools/Statistics (reconstruction)
• CommonTools/UtilAlgos (reconstruction)
• CommonTools/Utils (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @hatakeyamak, @jdolen, @gkasieczka, @cbernet, @clelange this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[yuanchao]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-878f89/17799/summary.html
COMMIT: 5e63bd9
CMSSW: CMSSW_12_1_X_2021-08-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34887/17799/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000317
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jpata]

• CommonTools/UtilAlgos/interface/MinSelector.h: MaxSelector exists and is used, perhaps for the sake of symmetry/future use it's better to keep this file
• CommonTools/UtilAlgos/interface/OrPairSelector.h: AndPairSelector exists and is used, reasoning the same as above
• CommonTools/Utils/interface/MinSelector.h: MaxSelector exists, it's also duplicated wrt. UtilAlgos
• CommonTools/Utils/interface/OrPairSelector.h: AndPairSelector exists, duplicated wrt. UtilAlgos
• CommonTools/Utils/interface/LazyResult.h: Created recently by @guitargeek, perhaps there is some use for this still foreseen

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24790

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • CommonTools/Utils/interface/LazyResult.h:
    • Deleted: 5e63bd9
    • Added: 4c277aa
  • CommonTools/UtilAlgos/interface/MinSelector.h:
    • Deleted: 5e63bd9
    • Added: 4c277aa
  • CommonTools/Utils/interface/OrPairSelector.h:
    • Deleted: 5e63bd9
    • Added: 74f57dd
  • CommonTools/UtilAlgos/interface/OrPairSelector.h:
    • Deleted: 5e63bd9
    • Added: 4c277aa
  • CommonTools/Utils/interface/MinSelector.h:
    • Deleted: 5e63bd9
    • Added: 74f57dd

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24790/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24790/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[yuanchao]

Looks like a bad idea to use restore instead of rebase. Anyway, taking the chance to fix the code checks.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34887/24791

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • CommonTools/Utils/interface/LazyResult.h:
    • Deleted: 5e63bd9
    • Added: 4c277aa
  • CommonTools/UtilAlgos/interface/MinSelector.h:
    • Deleted: 5e63bd9
    • Added: 4c277aa
    • Modified: 06c1e3e
  • CommonTools/Utils/interface/OrPairSelector.h:
    • Deleted: 5e63bd9
    • Added: 74f57dd
    • Modified: 06c1e3e
  • CommonTools/UtilAlgos/interface/OrPairSelector.h:
    • Deleted: 5e63bd9
    • Added: 4c277aa
    • Modified: 06c1e3e
  • CommonTools/Utils/interface/MinSelector.h:
    • Deleted: 5e63bd9
    • Added: 74f57dd
    • Modified: 06c1e3e

[cmsbuild]

Pull request #34887 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

[yuanchao]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-878f89/17920/summary.html
COMMIT: 06c1e3e
CMSSW: CMSSW_12_1_X_2021-08-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34887/17920/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical, removes unused headers
• no relevant reco differences (minor TICL difference likely from Non-reproducibility in ticlTracksters_ticlSimTracksters reco comparisons #34901)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Technical removal of unused header files