Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused headers/test files (DB packages) #34933

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Aug 18, 2021

PR description:

Implementing changes from #31870, on DB packages

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34933/24746

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

  • CondCore/DTPlugins (db)
  • CondFormats/CastorObjects (db, alca)
  • CondFormats/Common (db, alca)
  • CondFormats/DataRecord (db, alca)
  • CondFormats/HcalObjects (db, alca)
  • CondFormats/Serialization (db)
  • CondFormats/SiPixelObjects (db, alca)
  • CondTools/Ecal (db)
  • CondTools/L1Trigger (db, l1)
  • CondTools/RPC (db)
  • CondTools/SiStrip (db)
  • OnlineDB/CSCCondDB (db)
  • OnlineDB/EcalCondDB (db)

@malbouis, @yuanchao, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @VinInn, @OzAmram, @bsunanda, @dkotlins, @thomreis, @ferencek, @simonepigazzini, @mmusich, @argiro, @abdoulline, @seemasharmafnal, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Aug 18, 2021

please test

@tvami
Copy link
Contributor

tvami commented Aug 18, 2021

As part of the cleaning discussed in #31505

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbece8/17860/summary.html
COMMIT: c254d66
CMSSW: CMSSW_12_1_X_2021-08-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34933/17860/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000352
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000330
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 18, 2021

+alca

@ggovi
Copy link
Contributor Author

ggovi commented Aug 19, 2021

+1

@rekovic
Copy link
Contributor

rekovic commented Aug 31, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

please test
(to refresh the tests before merging)

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbece8/18199/summary.html
COMMIT: c254d66
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34933/18199/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3000376
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Sep 1, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants