Make operator functions 'hidden' friends of ExpressionAST

[Dr15Jones]

PR description:

The friends are now only available for argument dependent lookup if an ExpressionAST is directly being used. This avoids having an implicit conversion of arguments to ExpressionAST from happening.

This fixes a gcc 11 compilation problem.

PR validation:

The code compiles under gcc 11.

fixes #34775

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34942/24763

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FastSimulation/TrackingRecHitProducer (fastsim)

@civanch, @lveldere, @ssekmen, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d282a7/17876/summary.html
COMMIT: 4743cd8
CMSSW: CMSSW_12_1_X_2021-08-18-1500/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34942/17876/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider [GCC 11] Fix error "this pointer is null" in L1Trigger/DTTrigger #34767
• @makortel Migrate (Cosmic)ParametersDefinerForTP to esConsumes() #34924

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d282a7/17876/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d282a7/17876/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

@cms-sw/fastsim-l2 this is important to fix compilation problems in the gcc11 builds.

[Dr15Jones]

ping @cms-sw/fastsim-l2

[Dr15Jones]

ping @cms-sw/fastsim-l2

[civanch]

+1

@sbein, if you disagree, please, disable my sign.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1