Migrate some modules in RecoMET to esConsumes() #34943

makortel · 2021-08-19T00:20:00Z

PR description:

Part of #31061. These ones are fairly straightforward.

PR validation:

~~Code compiles.~~ Limited matrix runs.

cmsbuild · 2021-08-19T00:26:32Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34943/24764

ERROR: Build errors found during clang-tidy run.

RecoMET/METFilters/interface/EcalBoundaryInfoCalculator.h:270:47: error: functions that differ only in their return type cannot be overloaded [clang-diagnostic-error]
    std::unique_ptr<CaloNavigator<EcalDetId>> theEcalNav();
                                              ^
RecoMET/METFilters/interface/EcalBoundaryInfoCalculator.h:548:21: note: in instantiation of member function 'EcalBoundaryInfoCalculator<EEDetId>::initializeEcalNavigator' requested here
--
RecoMET/METFilters/interface/EcalBoundaryInfoCalculator.h:272:18: error: non-object type 'std::unique_ptr<CaloNavigator<EBDetId>> ()' is not assignable [clang-diagnostic-error]
      theEcalNav = std::make_unique<CaloNavigator<EcalDetId>>(
                 ^
RecoMET/METFilters/interface/EcalBoundaryInfoCalculator.h:548:21: note: in instantiation of member function 'EcalBoundaryInfoCalculator<EBDetId>::initializeEcalNavigator' requested here
--
RecoMET/METFilters/interface/EcalBoundaryInfoCalculator.h:281:12: error: no viable conversion from returned value of type 'std::unique_ptr<CaloNavigator<EBDetId>> ()' to function return type 'std::unique_ptr<CaloNavigator<EBDetId>>' [clang-diagnostic-error]
    return theEcalNav;
           ^
/cvmfs/cms-ib.cern.ch/nweek-02694/slc7_amd64_gcc900/external/gcc/9.3.0/lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../include/c++/9.3.0/bits/unique_ptr.h:250:12: note: candidate constructor template not viable: no known conversion from 'std::unique_ptr<CaloNavigator<EBDetId>> ()' to 'std::nullptr_t' (aka 'nullptr_t') for 1st argument
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2021-08-19T01:01:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34943/24765

This PR adds an extra 52KB to repository

cmsbuild · 2021-08-19T01:01:50Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoMET/METAlgorithms (reconstruction)
RecoMET/METFilters (reconstruction)
RecoMET/METPUSubtraction (reconstruction)
RecoMET/METProducers (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2021-08-19T01:27:50Z

@cmsbuild, please test

cmsbuild · 2021-08-19T04:21:43Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d38e0/17880/summary.html
COMMIT: cf3cfe7
CMSSW: CMSSW_12_1_X_2021-08-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34943/17880/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

4.22

----- Begin Fatal Exception 19-Aug-2021 05:30:11 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 160960 lumi: 277 event: 10001082 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module DQMMessageLogger/'DQMMessageLogger'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Prefetching for module BeamHaloSummaryProducer/'BeamHaloSummary'
   [5] Calling method for module CSCHaloDataProducer/'CSCHaloData'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<CaloGeometry,CaloGeometryRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 19-Aug-2021 05:31:10 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 305064 lumi: 36 event: 55020723 stream: 0
   [1] Running path 'Flag_EcalDeadCellBoundaryEnergyFilter'
   [2] Calling method for module EcalDeadCellBoundaryEnergyFilter/'EcalDeadCellBoundaryEnergyFilter'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<CaloTopology,CaloTopologyRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 19-Aug-2021 05:31:16 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 277069 lumi: 81 event: 36026102 stream: 0
   [1] Running path 'Flag_EcalDeadCellBoundaryEnergyFilter'
   [2] Calling method for module EcalDeadCellBoundaryEnergyFilter/'EcalDeadCellBoundaryEnergyFilter'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<CaloTopology,CaloTopologyRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
134.813134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2/step2_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_Fake

----- Begin Fatal Exception 19-Aug-2021 05:29:15 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 3
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Prefetching for module BeamHaloSummaryProducer/'BeamHaloSummary'
   [5] Calling method for module CSCHaloDataProducer/'CSCHaloData'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<CaloGeometry,CaloGeometryRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake1

----- Begin Fatal Exception 19-Aug-2021 05:29:17 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 5 stream: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Prefetching for module BeamHaloSummaryProducer/'BeamHaloSummary'
   [5] Calling method for module CSCHaloDataProducer/'CSCHaloData'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<CaloGeometry,CaloGeometryRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake2

----- Begin Fatal Exception 19-Aug-2021 05:29:27 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 1
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Prefetching for module BeamHaloSummaryProducer/'BeamHaloSummary'
   [5] Calling method for module CSCHaloDataProducer/'CSCHaloData'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<CaloGeometry,CaloGeometryRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

cmsbuild · 2021-08-19T19:25:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34943/24778

This PR adds an extra 52KB to repository

cmsbuild · 2021-08-19T19:25:47Z

Pull request #34943 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

makortel · 2021-08-19T19:35:36Z

@cmsbuild, please test

(limited matrix ran in a private test)

cmsbuild · 2021-08-19T22:45:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d38e0/17901/summary.html
COMMIT: 022f847
CMSSW: CMSSW_12_1_X_2021-08-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34943/17901/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000330
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

slava77 · 2021-08-20T23:50:43Z

+reconstruction

for #34943 022f847

code changes are technical, in line with the PR description
jenkins tests pass

cmsbuild · 2021-08-20T23:51:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-08-21T01:28:33Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Aug 19, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Aug 19, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 19, 2021

makortel force-pushed the esconsumesRecoMET branch from 20ecef2 to cf3cfe7 Compare August 19, 2021 00:54

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 19, 2021

makortel mentioned this pull request Aug 19, 2021

Migrate several straightforward cases in reconstruction to esConsumes cms-sw/framework-team#223

Closed

8 tasks

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 19, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 19, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 19, 2021

makortel added 7 commits August 19, 2021 21:07

Migrate CSCHaloAlgo to esConsumes()

78b1f35

Migrate PFMETAlgorithmMVA to esConsumes()

563a157

Migrate PFMETProducer to esConsumes()

7982f76

Migrate EEBadScFilter to esConsumes()

ca6b4b5

Migrate EcalBadCalibFilter to esConsumes()

69f88b8

Migrate EcalDeadCellBoundaryEnergyFilter to esConsumes()

5f1eefb

Migrate EcalLaserCorrFilter to esConsumes()

022f847

makortel force-pushed the esconsumesRecoMET branch from cf3cfe7 to 022f847 Compare August 19, 2021 19:19

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Aug 19, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 19, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 19, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 19, 2021

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Aug 20, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 21, 2021

cmsbuild merged commit 0202948 into cms-sw:master Aug 21, 2021

makortel deleted the esconsumesRecoMET branch August 21, 2021 01:30

This was referenced Aug 21, 2021

Run3-hcx310 Put back HcalDigiProducer.cc in SimCalorimetry/HcalSimProducers/src #34972

Merged

DataFormats/FEDRawData UBSAN warning fixed #35039

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate some modules in RecoMET to esConsumes() #34943

Migrate some modules in RecoMET to esConsumes() #34943

makortel commented Aug 19, 2021 •

edited

cmsbuild commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

makortel commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

makortel commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

slava77 commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

qliphy commented Aug 21, 2021

Migrate some modules in RecoMET to esConsumes() #34943

Migrate some modules in RecoMET to esConsumes() #34943

Conversation

makortel commented Aug 19, 2021 • edited

PR description:

PR validation:

cmsbuild commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

makortel commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

makortel commented Aug 19, 2021

cmsbuild commented Aug 19, 2021

Comparison Summary

slava77 commented Aug 20, 2021

cmsbuild commented Aug 20, 2021

qliphy commented Aug 21, 2021

makortel commented Aug 19, 2021 •

edited