Adding protections to PATTriggerProducer when the path has zero filters: 12_1

[Sam-Harper]

PR description:

As reported by @aescalante , PATTriggerProducer throws an out of bounds exception when run in " onlyStandAlone = cms.bool(False)" mode.

This is because there code assumes an HLT path will have at least one filter and has no protections for the case of a path having no filters. While this assumption seems reasonable, all HLT paths should have at least one filter (eg a prescale module) although personally I wouldnt assume this, in practice it fails as things like reconstruction_step and digi_step are also paths and have no filters

Therefore if PATTriggerProducer is run on data in full mode where the HLT was run together with other steps, it will fail. Note in production we use onlyStandAlone=True

This PR checks that a path has filters before accessing them.

No physics changes are expected, only changes is now workflows that crashed should now succeed.

PR validation:

Test config from Alberto now runs.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35043/24906

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @JyothsnaKomaragiri, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @mbluj, @gpetruc, @andrzejnovak, @demuller, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7351d9/18086/summary.html
COMMIT: 43d0871
CMSSW: CMSSW_12_1_X_2021-08-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35043/18086/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35043 43d0871

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1