Run3-trk08 Make sure the dd4hep algorithms provide the namespace to all created solids/volumes

[bsunanda]

PR description:

Make sure the dd4hep algorithms provide the namespace to all created solids/volumes

PR validation:

Used one of the scripts from standard test workflows for run3

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35065/24945

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35065/24945/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35065/24945/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35065/24946

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/TrackerCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@vargasa, @JanFSchulte, @VinInn, @mmusich, @ghugo83, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

This PR is a large perturbation of the names used in the DD4hep geometry. It is, in general, a good idea to add namespaces to the names to ensure uniqueness, but, at this late stage, there are dangers. There may be code we are not noticing that includes hard-coded references to particular names that this PR is changing.

The duplicate name problem is limited to the following solid names:

TECModule0Hybrid
TECModule0SideFrameLeft
TECModule0SideFrameRight
TECModule1Hybrid
TECModule1SideFrameLeft
TECModule1SideFrameRight
TECModule4Hybrid
TECModule4SideFrameLeft
TECModule4SideFrameRight

I suggest adding the namespace to these names only to avoid possible unforeseen consequences from a more comprehensive change.

[bsunanda]

All codes which depend on names get rid of namespace if it is a dd4hep. We have to revalidate all dd4hep workflows. I am starting with basic geometry comparisons which have found more issues than the detailed validation runs

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-067bc5/18123/summary.html
COMMIT: 7533c07
CMSSW: CMSSW_12_1_X_2021-08-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35065/18123/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , @cvuosalo , are there the same problems when we run from XML without DB?

[civanch]

+1

after discussion at https://indico.cern.ch/event/992973/?showDate=all&showSession=2 we decide merge this PR, which provides correct efficiency in tracker. @cvuosalo, other problems may be fixed on top of it.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1