Removed lexical_cast boost dependency in CondFormats #35091
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35091/24973
|
|
A new Pull Request was created by @Purva-Chaudhari for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -34,7 +34,7 @@ void SiStripDetSummary::add(DetId detid, float value) { | |||
| break; | |||
| } | |||
| detNum += layer * 10 + stereo; | |||
| // string name( detector + boost::lexical_cast<string>(layer) + boost::lexical_cast<string>(stereo) ); | |||
| // string name( detector + std::to_string(layer) + std::to_string(stereo) ); | |||
There was a problem hiding this comment.
is this commented out line needed?
There was a problem hiding this comment.
I was doubtful there if needed by other developers. Will remove it if its of no use
There was a problem hiding this comment.
@mmusich @pieterdavid please comment
There was a problem hiding this comment.
it serves no purpose I can think of. Please remove.
|
@cmsbuild , please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35091/24977
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cde96f/18174/summary.html Comparison SummarySummary:
|
|
+alca |
|
+1 |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Remove boost lexical cast dependency in CondFormats with corresponding stl alternatives
PR validation:
passed runTheMatrix
if this PR is a backport please specify the original PR and why you need to backport that PR:
@davidlange6 @vgvassilev