New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CondTools/RunInfo
to esConsumes
#35096
Migrate CondTools/RunInfo
to esConsumes
#35096
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35096/24982
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86adb2/18180/summary.html Comparison SummarySummary:
|
03a732a
to
48f9dcf
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35096/24989
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86adb2/18186/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of #31061. Migrates modules of
CondTools/RunInfo
to use esConsumes.Profited of the PR to modernize the code and address several static analyzer warnings.
PR validation:
It compiles. Also passed locally
EcalIntercalibConstants_O2O_test
which makes use ofCondTools/RunInfo/interface/BTransitionAnalyzer.h
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A