Migrate CondTools-Ecal modules to use esconsumes

[sroychow]

PR description:

Part of #31061. Migrate CondTools/Geometry modules to use esConsumes.

PR validation:

code compiles and scram build checker doesn't show the EventSetup get warnings.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35157/25086

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

• CondTools/Geometry (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@cvuosalo, @mmusich, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[sroychow]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75ab22/18325/summary.html
COMMIT: 49615d2
CMSSW: CMSSW_12_1_X_2021-09-05-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35157/18325/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000491
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000469
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[cvuosalo]

Was this PR fully tested? When I run the CondTools/​Geometry/​plugins/​PCaloGeometryBuilder.cc in CMSSW_12_1_X_2021-09-27-1100, I see this exception:

---- Begin Fatal Exception 27-Sep-2021 17:38:23 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PCaloGeometryBuilder label='CaloGeometryWriter'
Exception Message:
ESInputTag ESInputTag EcalBarrel_toDB must contain a ':' to separate the module and data labels.
----- End Fatal Exception -------------------------------------------------

It seems like this PR is using incorrect syntax.

[sroychow]

@cvuosalo you are right. Thanks for pointing out. I will make a PR to fix it.