Tracker Phase2 Digitizer framework update for BrickedPixel

[suchandradutta]

PR description:

Updating Phase2 Tracker Digitizer framework to include Bricked Pixel algorithm for the Inner Tracker (IT). The algorithm gets
activated for the phase 2 tracker geometry (T27) containing bricked pixels in TEPX&TFPX, as well as the central 1 (3) rod(s) of
TBPX L2 (L3 and 4). The detailed description of the geometry and corresponding changes got included in the PR#34120 . This update do not have any impact on the Outer Tracker digis (verified with Phase2 DQM plots). Attaching a few slides for the IT distributions.
BrickedPR.pdf

PR validation:

Validation done using SingleMuFlatPt2To100 events (runTheMatrix workflow 39104.0). No change observed in Digi DQM distributions for OT, as expected.

Verified that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@emiglior @franzglessgen

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35173/25099

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

• SimTracker/SiPhase2Digitizer (upgrade, simulation)

@cmsbuild, @AdrianoDee, @civanch, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c40f/18345/summary.html
COMMIT: 0e91ab5
CMSSW: CMSSW_12_1_X_2021-09-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35173/18345/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[srimanob]

Why do you need 2 newlines here?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35173/25104

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #35173 was updated. @cmsbuild, @AdrianoDee, @civanch, @srimanob, @mdhildreth can you please check and sign again.

[mmusich]

test parameters:

• workflow = 39034.0

[mmusich]

@cmsbuild, please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35173/25150

• This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35173/25150/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35173/25150/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35173/25152

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #35173 was updated. @cmsbuild, @AdrianoDee, @civanch, @srimanob, @mdhildreth can you please check and sign again.

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c40f/18443/summary.html
COMMIT: 0ba7ae0
CMSSW: CMSSW_12_1_X_2021-09-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35173/18443/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-99c40f/39034.0_TTbar_14TeV+2026D87+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[perrotta]

@srimanob @AdrianoDee the only update since last upgrade signature here is a namespace renamed with a lower case initial. I imagine that this won't change your evaluation, but please sign to confirm it if so,

[AdrianoDee]

+upgrade

(Only minor changes since last review)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1