Restore DataFormats/GeometrySurface/interface/private/extTkRotation.h

[perrotta]

PR description:

Restore the file DataFormats/GeometrySurface/interface/private/extTkRotation.h, that was erroneously removed by #35071
It is still needed by cmssw/DataFormats/GeometrySurface/interface/TkRotation.h, see #35071 (review)

PS: I had to apply code-format required adjustments, and therefore the file restored is not the exact carbon-copy of the one that was previously removed

PR validation:

It builds, as expected since only one removed header is restored here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35190/25125

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35190/25125/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35190/25125/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35190/25126

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

• DataFormats/GeometrySurface (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[smuzaffar]

@perrotta , as nothing in slc7_amd64_gcc900 IBs use this header so PR test for this arch are not goping to help much. Either we merge it and I can start ppc64le/aarch64 IBs or we run pr tests for ppc64le/aarch64 with full_cmssw=true

[perrotta]

please abort

[perrotta]

@perrotta , as nothing in slc7_amd64_gcc900 IBs use this header so PR test for this arch are not goping to help much. Either we merge it and I can start ppc64le/aarch64 IBs or we run pr tests for ppc64le/aarch64 with full_cmssw=true

Indeed... thank you @smuzaffar
I was with the idea that bot would have started the tests anyhow automatically even after my possible "+1".
I think we can even merge it as such, even without running the tests for ppc64le/aarch64: what do you suggest?

[smuzaffar]

I agree, just issue the merge command(with out the +1 comment) and I will make sure that we build ppc64/aarch64 IBs at 11h00

[perrotta]

I agree, just issue the merge command(with out the +1 comment) and I will make sure that we build ppc64/aarch64 IBs at 11h00

Ok, done.
As such I also managed to test that new (for me) button... :-)