Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Add TrackerAdditionalParametersPerDet_cfi to prevent exception in Tracker test script #35200

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

cvuosalo
Copy link
Contributor

@cvuosalo cvuosalo commented Sep 8, 2021

Backport of #35183 from 12_1. Adding a line to a config to prevent an exception occurring. See #35183 for more details.

The config in this PR is used to help validate geometry DB payloads, so it will be needed when the new DDD 12_0 geometry DB payloads are made.

The changed config in this PR was run for both Run 1 and Run 3 to check that it runs successfully with no exception.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for CMSSW_12_0_X.

It involves the following packages:

  • Geometry/TrackerGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @bsunanda, @mmusich, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 8, 2021

type bugfix

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 8, 2021

backport of #35183

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 8, 2021

@cmsbuild please test

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 9, 2021

please abort

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 9, 2021

Tests seem to be stuck

@cvuosalo
Copy link
Contributor Author

cvuosalo commented Sep 9, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2654fd/18467/summary.html
COMMIT: 76ad1d6
CMSSW: CMSSW_12_0_X_2021-09-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35200/18467/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Sep 10, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e3e9504 into cms-sw:CMSSW_12_0_X Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants