New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle more generator problems in external generator #35201
Handle more generator problems in external generator #35201
Conversation
This option avoids resetting the unix signal hanlder which was already set by the external application.
This tests failures for exceptions and unix signals which can occur in the constructor, begin lumi or event.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35201/25140
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf3e63/18431/summary.html Comparison SummarySummary:
|
I have a few additions coming within the hour. I'm just doing a more thorough testing of them. |
type bug |
urgent this will need a backport to 10_6 for production. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35201/25163
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
231d2cc
to
5753ffd
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35201/25164
|
Pull request #35201 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf3e63/18459/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
A new unit test was added to test the various failure routes are all handled properly.
PR validation:
The code compiles and the new unit test passes.