Run3-hcx331 Rearrange all plugins to the plugins directory in Calibration/HcalAlCaRecoProducers #35217

bsunanda · 2021-09-09T16:14:58Z

PR description:

Rearrange all plugins to the plugins directory in Calibration/HcalAlCaRecoProducers

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-09-09T16:23:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25165

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25165/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25165/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-09-09T17:22:51Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25168

This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25168/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25168/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-09-09T20:43:06Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25176

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25176/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25176/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

bsunanda · 2021-09-09T21:31:29Z

@cmsbuild Please test

cmsbuild · 2021-09-09T21:37:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25177

This PR adds an extra 32KB to repository

cmsbuild · 2021-09-09T21:37:35Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers (alca)

@yuanchao, @malbouis, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-09-10T00:33:43Z

Calibration/HcalAlCaRecoProducers/plugins/ProducerAnalyzer.cc

+    std::string hbheInput_;
+    std::string hoInput_;
+    std::string hfInput_;
+    std::string Tracks_;


According to the CMS code style rules, the members should start with a lowercase letter. This seems to be obeyed here except for the Tracks_

cmsbuild · 2021-09-10T00:59:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa9e47/18474/summary.html
COMMIT: d1c5882
CMSSW: CMSSW_12_1_X_2021-09-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35217/18474/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000979
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-09-10T01:23:06Z

Pull request #35217 was updated. @yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please check and sign again.

tvami · 2021-09-10T01:29:45Z

Hi @bsunanda thanks for changing the Tracks_, the other comment I'd have is to have the last commits squashed (I emailed you about that)

…aRecoProducers Small changes Code check small fix code check Code check make track_ instead of Track_

tvami · 2021-09-10T14:10:42Z

@cmsbuild , please test

cmsbuild · 2021-09-10T14:15:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35217/25183

This PR adds an extra 8KB to repository

cmsbuild · 2021-09-10T14:15:46Z

Pull request #35217 was updated. @yuanchao, @malbouis, @tvami, @francescobrivio can you please check and sign again.

cmsbuild · 2021-09-10T17:21:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa9e47/18492/summary.html
COMMIT: fd973b3
CMSSW: CMSSW_12_1_X_2021-09-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35217/18492/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000973
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

tvami · 2021-09-10T17:24:51Z

+alca

cmsbuild · 2021-09-10T17:25:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-10T18:01:31Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Sep 9, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Sep 9, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Sep 9, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 9, 2021

tvami reviewed Sep 10, 2021

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 10, 2021

Rearrange all plugins to the plugins directory in Calibration/HcalAlC…

fd973b3

…aRecoProducers Small changes Code check small fix code check Code check make track_ instead of Track_

bsunanda force-pushed the Run3-hcx331 branch from 0dbd71f to fd973b3 Compare September 10, 2021 14:08

cmsbuild added code-checks-pending and removed code-checks-approved labels Sep 10, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 10, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 10, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 10, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Sep 10, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 10, 2021

cmsbuild merged commit 2d4d075 into cms-sw:master Sep 10, 2021

This was referenced Sep 11, 2021

add 11634.7 wf for 2021 ttbar mkFit to the short matrix #35235

Merged

modernize RecoVertex/BeamSpotProducer #35236

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-hcx331 Rearrange all plugins to the plugins directory in Calibration/HcalAlCaRecoProducers #35217

Run3-hcx331 Rearrange all plugins to the plugins directory in Calibration/HcalAlCaRecoProducers #35217

bsunanda commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

bsunanda commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

tvami Sep 10, 2021

cmsbuild commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

tvami commented Sep 10, 2021

tvami commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

tvami commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

perrotta commented Sep 10, 2021

Run3-hcx331 Rearrange all plugins to the plugins directory in Calibration/HcalAlCaRecoProducers #35217

Run3-hcx331 Rearrange all plugins to the plugins directory in Calibration/HcalAlCaRecoProducers #35217

Conversation

bsunanda commented Sep 9, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

bsunanda commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

cmsbuild commented Sep 9, 2021

tvami Sep 10, 2021

Choose a reason for hiding this comment

cmsbuild commented Sep 10, 2021

Comparison Summary

cmsbuild commented Sep 10, 2021

tvami commented Sep 10, 2021

tvami commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

Comparison Summary

tvami commented Sep 10, 2021

cmsbuild commented Sep 10, 2021

perrotta commented Sep 10, 2021